Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
66e502c6
Commit
66e502c6
authored
Nov 14, 2020
by
Thomas Randolph
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename app eventHub to correct notesEventHub
parent
775f9093
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
6 deletions
+8
-6
app/assets/javascripts/diffs/components/app.vue
app/assets/javascripts/diffs/components/app.vue
+8
-6
No files found.
app/assets/javascripts/diffs/components/app.vue
View file @
66e502c6
...
@@ -10,7 +10,8 @@ import PanelResizer from '~/vue_shared/components/panel_resizer.vue';
...
@@ -10,7 +10,8 @@ import PanelResizer from '~/vue_shared/components/panel_resizer.vue';
import
glFeatureFlagsMixin
from
'
~/vue_shared/mixins/gl_feature_flags_mixin
'
;
import
glFeatureFlagsMixin
from
'
~/vue_shared/mixins/gl_feature_flags_mixin
'
;
import
{
isSingleViewStyle
}
from
'
~/helpers/diffs_helper
'
;
import
{
isSingleViewStyle
}
from
'
~/helpers/diffs_helper
'
;
import
{
updateHistory
}
from
'
~/lib/utils/url_utility
'
;
import
{
updateHistory
}
from
'
~/lib/utils/url_utility
'
;
import
eventHub
from
'
../../notes/event_hub
'
;
import
notesEventHub
from
'
../../notes/event_hub
'
;
import
CompareVersions
from
'
./compare_versions.vue
'
;
import
CompareVersions
from
'
./compare_versions.vue
'
;
import
DiffFile
from
'
./diff_file.vue
'
;
import
DiffFile
from
'
./diff_file.vue
'
;
import
NoChanges
from
'
./no_changes.vue
'
;
import
NoChanges
from
'
./no_changes.vue
'
;
...
@@ -280,8 +281,8 @@ export default {
...
@@ -280,8 +281,8 @@ export default {
created
()
{
created
()
{
this
.
adjustView
();
this
.
adjustView
();
e
ventHub
.
$once
(
'
fetchDiffData
'
,
this
.
fetchData
);
notesE
ventHub
.
$once
(
'
fetchDiffData
'
,
this
.
fetchData
);
e
ventHub
.
$on
(
'
refetchDiffData
'
,
this
.
refetchDiffData
);
notesE
ventHub
.
$on
(
'
refetchDiffData
'
,
this
.
refetchDiffData
);
this
.
CENTERED_LIMITED_CONTAINER_CLASSES
=
CENTERED_LIMITED_CONTAINER_CLASSES
;
this
.
CENTERED_LIMITED_CONTAINER_CLASSES
=
CENTERED_LIMITED_CONTAINER_CLASSES
;
this
.
unwatchDiscussions
=
this
.
$watch
(
this
.
unwatchDiscussions
=
this
.
$watch
(
...
@@ -302,8 +303,9 @@ export default {
...
@@ -302,8 +303,9 @@ export default {
beforeDestroy
()
{
beforeDestroy
()
{
diffsApp
.
deinstrument
();
diffsApp
.
deinstrument
();
eventHub
.
$off
(
'
fetchDiffData
'
,
this
.
fetchData
);
notesEventHub
.
$off
(
'
refetchDiffData
'
,
this
.
refetchDiffData
);
eventHub
.
$off
(
'
refetchDiffData
'
,
this
.
refetchDiffData
);
notesEventHub
.
$off
(
'
fetchDiffData
'
,
this
.
fetchData
);
this
.
removeEventListeners
();
this
.
removeEventListeners
();
},
},
methods
:
{
methods
:
{
...
@@ -373,7 +375,7 @@ export default {
...
@@ -373,7 +375,7 @@ export default {
}
}
if
(
!
this
.
isNotesFetched
)
{
if
(
!
this
.
isNotesFetched
)
{
e
ventHub
.
$emit
(
'
fetchNotesData
'
);
notesE
ventHub
.
$emit
(
'
fetchNotesData
'
);
}
}
},
},
setDiscussions
()
{
setDiscussions
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment