Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
66ebf02c
Commit
66ebf02c
authored
Dec 04, 2020
by
GitLab Bot
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add latest changes from gitlab-org/security/gitlab@13-6-stable-ee
parent
d00f14d7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
app/graphql/types/user_type.rb
app/graphql/types/user_type.rb
+1
-1
changelogs/unreleased/security-290-graphql-exposed-email.yml
changelogs/unreleased/security-290-graphql-exposed-email.yml
+5
-0
spec/requests/api/graphql/user_query_spec.rb
spec/requests/api/graphql/user_query_spec.rb
+1
-1
No files found.
app/graphql/types/user_type.rb
View file @
66ebf02c
...
...
@@ -19,7 +19,7 @@ module Types
field
:state
,
Types
::
UserStateEnum
,
null:
false
,
description:
'State of the user'
field
:email
,
GraphQL
::
STRING_TYPE
,
null:
true
,
description:
'User email'
description:
'User email'
,
method: :public_email
field
:avatar_url
,
GraphQL
::
STRING_TYPE
,
null:
true
,
description:
"URL of the user's avatar"
field
:web_url
,
GraphQL
::
STRING_TYPE
,
null:
false
,
...
...
changelogs/unreleased/security-290-graphql-exposed-email.yml
0 → 100644
View file @
66ebf02c
---
title
:
'
GraphQL
User:
do
not
expose
email
if
set
to
private'
merge_request
:
author
:
type
:
security
spec/requests/api/graphql/user_query_spec.rb
View file @
66ebf02c
...
...
@@ -82,7 +82,7 @@ RSpec.describe 'getting user information' do
'username'
=>
presenter
.
username
,
'webUrl'
=>
presenter
.
web_url
,
'avatarUrl'
=>
presenter
.
avatar_url
,
'email'
=>
presenter
.
email
'email'
=>
presenter
.
public_
email
))
expect
(
graphql_data
[
'user'
][
'status'
]).
to
match
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment