Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
673c1456
Commit
673c1456
authored
Jan 21, 2016
by
Gabriel Mazetto
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix redirect after login for non root_urls started on Geo node
parent
754bb9ac
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
app/controllers/sessions_controller.rb
app/controllers/sessions_controller.rb
+3
-2
No files found.
app/controllers/sessions_controller.rb
View file @
673c1456
...
@@ -55,7 +55,7 @@ class SessionsController < Devise::SessionsController
...
@@ -55,7 +55,7 @@ class SessionsController < Devise::SessionsController
# Prevent a 'you are already signed in' message directly after signing:
# Prevent a 'you are already signed in' message directly after signing:
# we should never redirect to '/users/sign_in' after signing in successfully.
# we should never redirect to '/users/sign_in' after signing in successfully.
if
redirect_uri
.
path
==
new_user_session_path
if
redirect_uri
.
path
==
new_user_session_path
re
direct_to
=
root_url
re
turn
true
elsif
Gitlab
::
Geo
.
geo_node?
(
host:
redirect_uri
.
host
,
port:
redirect_uri
.
port
)
elsif
Gitlab
::
Geo
.
geo_node?
(
host:
redirect_uri
.
host
,
port:
redirect_uri
.
port
)
redirect_to
=
redirect_uri
.
to_s
redirect_to
=
redirect_uri
.
to_s
end
end
...
@@ -89,7 +89,8 @@ class SessionsController < Devise::SessionsController
...
@@ -89,7 +89,8 @@ class SessionsController < Devise::SessionsController
def
gitlab_geo_login
def
gitlab_geo_login
if
!
signed_in?
&&
Gitlab
::
Geo
.
enabled?
&&
Gitlab
::
Geo
.
readonly?
if
!
signed_in?
&&
Gitlab
::
Geo
.
enabled?
&&
Gitlab
::
Geo
.
readonly?
# share full url with primary node by shared session
# share full url with primary node by shared session
session
[
:geo_node_return_to
]
=
@redirect_to
user_return_to
=
URI
.
join
(
root_url
,
session
[
:user_return_to
]).
to_s
session
[
:geo_node_return_to
]
=
@redirect_to
||
user_return_to
login_uri
=
URI
.
join
(
Gitlab
::
Geo
.
primary_node
.
url
,
new_session_path
(
:user
)).
to_s
login_uri
=
URI
.
join
(
Gitlab
::
Geo
.
primary_node
.
url
,
new_session_path
(
:user
)).
to_s
redirect_to
login_uri
redirect_to
login_uri
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment