Commit 6838c16c authored by kushalpandya's avatar kushalpandya

Minor refactor based on review feedback

parent b487a32c
...@@ -23,6 +23,6 @@ ...@@ -23,6 +23,6 @@
- elsif type == 'select' - elsif type == 'select'
= form.select name, options_for_select(choices, value ? value : default_choice), {}, { class: "form-control" } = form.select name, options_for_select(choices, value ? value : default_choice), {}, { class: "form-control" }
- elsif type == 'password' - elsif type == 'password'
= form.password_field name, autocomplete: "new-password", class: "form-control", required: value.present? ? nil : :required = form.password_field name, autocomplete: "new-password", class: "form-control", required: value.blank? && :required
- if help - if help
%span.help-block= help %span.help-block= help
...@@ -65,7 +65,8 @@ feature 'Setup Jira service', :feature, :js do ...@@ -65,7 +65,8 @@ feature 'Setup Jira service', :feature, :js do
click_button('Test settings and save changes') click_button('Test settings and save changes')
wait_for_requests wait_for_requests
expect(page).to have_content('Test failed.Save anyway') expect(find('.flash-container-page')).to have_content 'Test failed.'
expect(find('.flash-container-page')).to have_content 'Save anyway'
find('.flash-alert .flash-action').trigger('click') find('.flash-alert .flash-action').trigger('click')
wait_for_requests wait_for_requests
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment