Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
69b7537d
Commit
69b7537d
authored
May 11, 2020
by
Justin Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor backend to be clearer on values
And remove use of send / replace with public_send
parent
6396fba6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
8 deletions
+11
-8
app/models/service.rb
app/models/service.rb
+11
-8
No files found.
app/models/service.rb
View file @
69b7537d
...
...
@@ -172,19 +172,22 @@ class Service < ApplicationRecord
def
configurable_events_json
configurable_events
.
map
do
|
event
|
event_
method
=
ServicesHelper
.
service_event_field_name
(
event
)
event_
field_name
=
ServicesHelper
.
service_event_field_name
(
event
)
result
=
{
title:
event
,
name:
event_
method
,
value:
se
nd
(
event_method
),
# rubocop:disable GitlabSecurity/PublicSend
name:
event_
field_name
,
value:
se
lf
[
event_field_name
],
description:
self
.
class
.
event_description
(
event
)
}
field
=
event_field
(
event
)
if
field
result
.
merge
({
field:
{
name:
field
[
:name
],
value:
send
(
field
[
:name
])
}
})
# rubocop:disable GitlabSecurity/PublicSend
else
result
if
field
=
event_field
(
event
)
result
[
:field
]
=
{
name:
field
[
:name
],
value:
public_send
(
field
[
:name
])
# rubocop:disable GitlabSecurity/PublicSend
}
end
result
end
.
to_json
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment