Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6a0509ff
Commit
6a0509ff
authored
Sep 25, 2020
by
Alex Kalderimis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove graphql_lookahead_support feature flag
parent
12dd6301
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
25 deletions
+5
-25
app/graphql/resolvers/concerns/looks_ahead.rb
app/graphql/resolvers/concerns/looks_ahead.rb
+0
-4
changelogs/unreleased/ajk-remove-graphql_lookahead_support.yml
...elogs/unreleased/ajk-remove-graphql_lookahead_support.yml
+5
-0
config/feature_flags/development/graphql_lookahead_support.yml
...g/feature_flags/development/graphql_lookahead_support.yml
+0
-7
spec/graphql/resolvers/concerns/looks_ahead_spec.rb
spec/graphql/resolvers/concerns/looks_ahead_spec.rb
+0
-14
No files found.
app/graphql/resolvers/concerns/looks_ahead.rb
View file @
6a0509ff
...
...
@@ -3,8 +3,6 @@
module
LooksAhead
extend
ActiveSupport
::
Concern
FEATURE_FLAG
=
:graphql_lookahead_support
included
do
attr_accessor
:lookahead
end
...
...
@@ -16,8 +14,6 @@ module LooksAhead
end
def
apply_lookahead
(
query
)
return
query
unless
Feature
.
enabled?
(
FEATURE_FLAG
)
selection
=
node_selection
includes
=
preloads
.
each
.
flat_map
do
|
name
,
requirements
|
...
...
changelogs/unreleased/ajk-remove-graphql_lookahead_support.yml
0 → 100644
View file @
6a0509ff
---
title
:
Remove graphql_lookahead_support feature flag
merge_request
:
43438
author
:
type
:
added
config/feature_flags/development/graphql_lookahead_support.yml
deleted
100644 → 0
View file @
12dd6301
---
name
:
graphql_lookahead_support
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
false
spec/graphql/resolvers/concerns/looks_ahead_spec.rb
View file @
6a0509ff
...
...
@@ -117,20 +117,6 @@ RSpec.describe LooksAhead do
query
.
result
end
context
'the feature flag is off'
do
before
do
stub_feature_flags
(
described_class
::
FEATURE_FLAG
=>
false
)
end
it_behaves_like
'a working query on the test schema'
it
'does not preload labels on issues'
do
expect
(
the_user
.
issues
).
not_to
receive
(
:preload
).
with
(
:labels
)
query
.
result
end
end
it
'issues fewer queries than the naive approach'
do
the_user
.
reload
# ensure no attributes are loaded before we begin
naive
=
<<-
GQL
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment