Code review feedback

Use predicate method and boolean rather than string

app/helpers/projects_helper.rb

@@ -363,7 +363,7 @@ module ProjectsHelper
   end
 
   def grafana_integration_enabled
-    @project.grafana_integration&.enabled
+    @project.grafana_integration&.enabled?
   end
 
   private

app/models/grafana_integration.rb

@@ -17,8 +17,8 @@ class GrafanaIntegration < ApplicationRecord
   validates :enabled, inclusion: { in: [true, false] }
 
   def client
-    if enabled?
-      @client ||= ::Grafana::Client.new(api_url: grafana_url.chomp('/'), token: token)
-    end
+    return unless enabled?
+
+    @client ||= ::Grafana::Client.new(api_url: grafana_url.chomp('/'), token: token)
   end
 end

changelogs/unreleased/33672-add-enable-checkbox-for-grafana-authentication-settings.yml

 ---
-title: Add flag to enable and disable grafana integration
+title: Migrate enabled flag on grafana_integrations table
 merge_request: 19234
 author:
 type: changed

spec/factories/grafana_integrations.rb

@@ -5,6 +5,6 @@ FactoryBot.define do
     project
     grafana_url { 'https://grafana.example.com' }
     token { SecureRandom.hex(10) }
-    enabled { 'true' }
+    enabled { true }
   end
 end