Merge branch '326721-remove-load-balancing-ff' into 'master'

Rollout of load_balancing_for_bulk_cron_workers ff [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!61993

config/feature_flags/development/load_balancing_for_bulk_cron_workers.yml

----
-name: load_balancing_for_bulk_cron_workers
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58345
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326721
-milestone: '13.11'
-type: development
-group: group::global search
-default_enabled: false

ee/app/workers/elastic_index_bulk_cron_worker.rb

@@ -7,7 +7,7 @@ class ElasticIndexBulkCronWorker # rubocop:disable Scalability/IdempotentWorker
   urgency :throttled
   # Even though this worker is idempotent, until https://gitlab.com/gitlab-org/gitlab/-/issues/325291 is done
   # we can't use it with read-only database replicas
-  data_consistency :delayed, feature_flag: :load_balancing_for_bulk_cron_workers
+  data_consistency :delayed
 
   private
 

ee/app/workers/elastic_index_initial_bulk_cron_worker.rb

@@ -7,7 +7,7 @@ class ElasticIndexInitialBulkCronWorker # rubocop:disable Scalability/Idempotent
   urgency :throttled
   # Even though this worker is idempotent, until https://gitlab.com/gitlab-org/gitlab/-/issues/325291 is done
   # we can't use it with read-only database replicas
-  data_consistency :delayed, feature_flag: :load_balancing_for_bulk_cron_workers
+  data_consistency :delayed
 
   private
 

ee/changelogs/unreleased/326721-remove-load-balancing-ff.yml

+---
+title: 'Advanced Search: Allow indexing workers to use replicas'
+merge_request: 61993
+author:
+type: performance

ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb

@@ -50,6 +50,5 @@ RSpec.describe ElasticIndexBulkCronWorker do
 
   it_behaves_like 'worker with data consistency',
                   described_class,
-                  feature_flag: :load_balancing_for_bulk_cron_workers,
                   data_consistency: :delayed
 end