Merge branch '273142-fj-enable-avatar-with-full-url' into 'master'

Enable avatar with full url

See merge request gitlab-org/gitlab!46206

app/helpers/page_layout_helper.rb

@@ -57,10 +57,7 @@ module PageLayoutHelper
 
     subject = @project || @user || @group
 
-    args = {}
-    args[:only_path] = false if Feature.enabled?(:avatar_with_host)
-
-    image = subject.avatar_url(args) if subject.present?
+    image = subject.avatar_url(only_path: false) if subject.present?
     image || default
   end
 

changelogs/unreleased/273142-fj-enable-avatar-with-full-url.yml

+---
+title: Enable rendering avatars with full url
+merge_request: 46206
+author:
+type: fixed

config/feature_flags/development/avatar_with_host.yml

----
-name: avatar_with_host
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45776
-rollout_issue_url:
-type: development
-group: group::editor
-default_enabled: false

spec/helpers/page_layout_helper_spec.rb

@@ -82,16 +82,6 @@ RSpec.describe PageLayoutHelper do
           expect(helper.page_image).to match_asset_path 'assets/gitlab_logo.png'
         end
       end
-
-      context 'if avatar_with_host is disabled' do
-        it "#{type.titlecase} does not generate avatar full url" do
-          stub_feature_flags(avatar_with_host: false)
-
-          assign(type, object)
-
-          expect(helper.page_image).to eq object.avatar_url(only_path: true)
-        end
-      end
     end
   end