handle null and NaN id

6cc3d6e9 · Simon Knox · b66257de · 6cc3d6e9
Commit 6cc3d6e9 authored Oct 18, 2017 by Simon Knox
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 5 deletions

ee/app/assets/javascripts/boards/stores/boards_store_ee.js ee/app/assets/javascripts/boards/stores/boards_store_ee.js +5 -5

No files found.
--- a/ee/app/assets/javascripts/boards/stores/boards_store_ee.js
+++ b/ee/app/assets/javascripts/boards/stores/boards_store_ee.js
@@ -39,11 +39,11 @@ class BoardsStoreEE {
    };

    let milestoneTitle = this.store.boardConfig.milestoneTitle;
-    if (this.store.boardConfig.milestoneId !== -1) {
-      if (this.store.boardConfig.milestoneId === 0) {
-        milestoneTitle = 'No+Milestone';
-      }
-      updateFilterPath('milestone_title', encodeURIComponent(milestoneTitle));
+    if (this.store.boardConfig.milestoneId === 0) {
+      milestoneTitle = 'No+Milestone';
+    }
+    if (milestoneTitle) {
+      updateFilterPath('milestone_title', milestoneTitle);
      this.store.cantEdit.push('milestone');
    }