Commit 715d333a authored by Sean McGivern's avatar Sean McGivern

Merge branch 'terrichu-master-patch-50773' into 'master'

Add how to test suggestion to code review guidelines

See merge request gitlab-org/gitlab!53376
parents f0904c43 91a3c4ab
......@@ -281,6 +281,8 @@ first time.
of your shiny new branch, read through the entire diff. Does it make sense?
Did you include something unrelated to the overall purpose of the changes? Did
you forget to remove any debugging code?
- Consider providing instructions on how to test the merge request. This can be
helpful for reviewers not familiar with the product feature or area of the codebase.
<!-- vale gitlab.FutureTense = NO -->
- Be grateful for the reviewer's suggestions. ("Good call. I'll make that
change.")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment