Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
718350dc
Commit
718350dc
authored
May 12, 2017
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Wait for requests after each Spinach scenario instead of feature
parent
ec1a3c09
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
8 deletions
+3
-8
features/support/env.rb
features/support/env.rb
+2
-2
spec/support/wait_for_requests.rb
spec/support/wait_for_requests.rb
+1
-6
No files found.
features/support/env.rb
View file @
718350dc
...
@@ -30,8 +30,8 @@ Spinach.hooks.before_run do
...
@@ -30,8 +30,8 @@ Spinach.hooks.before_run do
include
FactoryGirl
::
Syntax
::
Methods
include
FactoryGirl
::
Syntax
::
Methods
end
end
Spinach
.
hooks
.
after_
feature
do
|
feature_data
|
Spinach
.
hooks
.
after_
scenario
do
|
scenario_data
,
step_definitions
|
if
feature_data
.
scenarios
.
flat_map
(
&
:tags
)
.
include?
(
'javascript'
)
if
scenario_data
.
tags
.
include?
(
'javascript'
)
include
WaitForRequests
include
WaitForRequests
wait_for_requests_complete
wait_for_requests_complete
end
end
...
...
spec/support/wait_for_requests.rb
View file @
718350dc
...
@@ -10,17 +10,12 @@ module WaitForRequests
...
@@ -10,17 +10,12 @@ module WaitForRequests
def
wait_for_requests_complete
def
wait_for_requests_complete
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
block_requests!
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
block_requests!
wait_for
(
'pending AJAX requests complete'
)
do
wait_for
(
'pending AJAX requests complete'
)
do
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
num_active_requests
.
zero?
&&
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
num_active_requests
.
zero?
finished_all_requests?
end
end
ensure
ensure
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
allow_requests!
Gitlab
::
Testing
::
RequestBlockerMiddleware
.
allow_requests!
end
end
def
finished_all_requests?
finished_all_ajax_requests?
&&
finished_all_vue_resource_requests?
end
# Waits until the passed block returns true
# Waits until the passed block returns true
def
wait_for
(
condition_name
,
max_wait_time:
Capybara
.
default_max_wait_time
,
polling_interval:
0.01
)
def
wait_for
(
condition_name
,
max_wait_time:
Capybara
.
default_max_wait_time
,
polling_interval:
0.01
)
wait_until
=
Time
.
now
+
max_wait_time
.
seconds
wait_until
=
Time
.
now
+
max_wait_time
.
seconds
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment