Commit 7328b143 authored by Pedro Pombeiro's avatar Pedro Pombeiro

Track event for new Group runners view

parent 91a42f8a
...@@ -11,6 +11,8 @@ class Groups::RunnersController < Groups::ApplicationController ...@@ -11,6 +11,8 @@ class Groups::RunnersController < Groups::ApplicationController
def index def index
finder = Ci::RunnersFinder.new(current_user: current_user, params: { group: @group }) finder = Ci::RunnersFinder.new(current_user: current_user, params: { group: @group })
@group_runners_limited_count = finder.execute.except(:limit, :offset).page.total_count_with_limit(:all, limit: 1000) @group_runners_limited_count = finder.execute.except(:limit, :offset).page.total_count_with_limit(:all, limit: 1000)
Gitlab::Tracking.event(self.class.name, 'index', user: current_user, namespace: @group)
end end
def runner_list_group_view_vue_ui_enabled def runner_list_group_view_vue_ui_enabled
......
...@@ -17,7 +17,7 @@ RSpec.describe Groups::RunnersController do ...@@ -17,7 +17,7 @@ RSpec.describe Groups::RunnersController do
sign_in(user) sign_in(user)
end end
describe '#index' do describe '#index', :snowplow do
context 'when user is owner' do context 'when user is owner' do
before do before do
group.add_owner(user) group.add_owner(user)
...@@ -30,6 +30,12 @@ RSpec.describe Groups::RunnersController do ...@@ -30,6 +30,12 @@ RSpec.describe Groups::RunnersController do
expect(response).to render_template(:index) expect(response).to render_template(:index)
expect(assigns(:group_runners_limited_count)).to be(2) expect(assigns(:group_runners_limited_count)).to be(2)
end end
it 'tracks the event' do
get :index, params: { group_id: group }
expect_snowplow_event(category: described_class.name, action: 'index', user: user, namespace: group)
end
end end
context 'when user is not owner' do context 'when user is not owner' do
...@@ -42,6 +48,12 @@ RSpec.describe Groups::RunnersController do ...@@ -42,6 +48,12 @@ RSpec.describe Groups::RunnersController do
expect(response).to have_gitlab_http_status(:not_found) expect(response).to have_gitlab_http_status(:not_found)
end end
it 'does not track the event' do
get :index, params: { group_id: group }
expect_no_snowplow_event
end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment