Always use symbols for type on LabelsHelper#link_to_label

73bfc15c · Douglas Barbosa Alexandre · 2deef25e · 73bfc15c · 73bfc15c
Commit 73bfc15c authored Oct 11, 2016 by Douglas Barbosa Alexandre
Showing with 2 additions and 2 deletions

app/helpers/labels_helper.rb app/helpers/labels_helper.rb +1 -1

app/views/projects/merge_requests/_merge_request.html.haml app/views/projects/merge_requests/_merge_request.html.haml +1 -1

No files found.
--- a/app/helpers/labels_helper.rb
+++ b/app/helpers/labels_helper.rb
@@ -46,7 +46,7 @@ module LabelsHelper
    end
  end
-  def label_filter_path(subject, label, type: issue)
+  def label_filter_path(subject, label, type: :issue)
    case subject
    when Group
      send("#{type.to_s.pluralize}_group_path",

--- a/app/views/projects/merge_requests/_merge_request.html.haml
+++ b/app/views/projects/merge_requests/_merge_request.html.haml
@@ -62,7 +62,7 @@
    - if merge_request.labels.any?
      &nbsp;
      - merge_request.labels.each do |label|
-        = link_to_label(label, subject: merge_request.project, type: 'merge_request')
+        = link_to_label(label, subject: merge_request.project, type: :merge_request)
    - if merge_request.tasks?
      &nbsp;
      %span.task-status