Merge branch '331693-remove-helm-feature-flag' into 'master'

Release the Helm charts registry

See merge request gitlab-org/gitlab!65768

config/feature_flags/development/helm_packages.yml

----
-name: helm_packages
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61014
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/331693
-milestone: '14.0'
-type: development
-group: group::package
-default_enabled: false

doc/administration/packages/index.md

@@ -26,6 +26,7 @@ The Package Registry supports the following formats:
 <tr><td><a href="https://docs.gitlab.com/ee/user/packages/nuget_repository/index.html">NuGet</a></td><td>12.8+</td></tr>
 <tr><td><a href="https://docs.gitlab.com/ee/user/packages/pypi_repository/index.html">PyPI</a></td><td>12.10+</td></tr>
 <tr><td><a href="https://docs.gitlab.com/ee/user/packages/generic_packages/index.html">Generic packages</a></td><td>13.5+</td></tr>
+<tr><td><a href="https://docs.gitlab.com/ee/user/packages/helm_repository/index.html">Helm Charts</a></td><td>14.1+</td></tr>
 </table>
 </div>
 </div>

doc/api/packages.md

@@ -26,7 +26,7 @@ GET /projects/:id/packages
 | `id`      | integer/string | yes | ID or [URL-encoded path of the project](index.md#namespaced-path-encoding) |
 | `order_by`| string | no | The field to use as order. One of `created_at` (default), `name`, `version`, or `type`. |
 | `sort`    | string | no | The direction of the order, either `asc` (default) for ascending order or `desc` for descending order. |
-| `package_type` | string | no | Filter the returned packages by type. One of `conan`, `maven`, `npm`, `pypi`, `composer`, `nuget`, or `golang`. (_Introduced in GitLab 12.9_)
+| `package_type` | string | no | Filter the returned packages by type. One of `conan`, `maven`, `npm`, `pypi`, `composer`, `nuget`, `helm`, or `golang`. (_Introduced in GitLab 12.9_)
 | `package_name` | string | no | Filter the project packages with a fuzzy search by name. (_Introduced in GitLab 12.9_)
 | `include_versionless` | boolean | no | When set to true, versionless packages are included in the response. (_Introduced in GitLab 13.8_)
 | `status` | string | no | Filter the returned packages by status. One of `default` (default), `hidden`, or `processing`. (_Introduced in GitLab 13.9_)
@@ -91,7 +91,7 @@ GET /groups/:id/packages
 | `exclude_subgroups` | boolean | false | If the parameter is included as true, packages from projects from subgroups are not listed. Default is `false`. |
 | `order_by`| string | no | The field to use as order. One of `created_at` (default), `name`, `version`, `type`, or `project_path`. |
 | `sort`    | string | no | The direction of the order, either `asc` (default) for ascending order or `desc` for descending order. |
-| `package_type` | string | no | Filter the returned packages by type. One of `conan`, `maven`, `npm`, `pypi`, `composer`, `nuget`, or `golang`. (_Introduced in GitLab 12.9_) |
+| `package_type` | string | no | Filter the returned packages by type. One of `conan`, `maven`, `npm`, `pypi`, `composer`, `nuget`, `helm`, or `golang`. (_Introduced in GitLab 12.9_) |
 | `package_name` | string | no | Filter the project packages with a fuzzy search by name. (_[Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/30980) in GitLab 13.0_)
 | `include_versionless` | boolean | no | When set to true, versionless packages are included in the response. (_Introduced in GitLab 13.8_)
 | `status` | string | no | Filter the returned packages by status. One of `default` (default), `hidden`, or `processing`. (_Introduced in GitLab 13.9_)

doc/api/packages/helm.md

@@ -22,23 +22,6 @@ These endpoints do not adhere to the standard API authentication methods.
 See the [Helm registry documentation](../../user/packages/helm_repository/index.md)
 for details on which headers and token types are supported.
 
-## Enable the Helm API
-
-The Helm API for GitLab is behind a feature flag that is disabled by default. GitLab
-administrators with access to the GitLab Rails console can enable this API for your instance.
-
-To enable it:
-
-```ruby
-Feature.enable(:helm_packages)
-```
-
-To disable it:
-
-```ruby
-Feature.disable(:helm_packages)
-```
-
 ## Download a chart index
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62757) in GitLab 14.1.

doc/api/plan_limits.md

@@ -38,6 +38,7 @@ Example response:
 {
   "conan_max_file_size": 3221225472,
   "generic_packages_max_file_size": 5368709120,
+  "helm_max_file_size": 5242880,
   "maven_max_file_size": 3221225472,
   "npm_max_file_size": 524288000,
   "nuget_max_file_size": 524288000,
@@ -59,6 +60,7 @@ PUT /application/plan_limits
 | `plan_name`                       | string  | yes      | Name of the plan to update. |
 | `conan_max_file_size`             | integer | no       | Maximum Conan package file size in bytes. |
 | `generic_packages_max_file_size`  | integer | no       | Maximum generic package file size in bytes. |
+| `helm_max_file_size`              | integer | no       | Maximum Helm chart file size in bytes. |
 | `maven_max_file_size`             | integer | no       | Maximum Maven package file size in bytes. |
 | `npm_max_file_size`               | integer | no       | Maximum NPM package file size in bytes. |
 | `nuget_max_file_size`             | integer | no       | Maximum NuGet package file size in bytes. |
@@ -75,6 +77,7 @@ Example response:
 {
   "conan_max_file_size": 3221225472,
   "generic_packages_max_file_size": 5368709120,
+  "helm_max_file_size": 5242880,
   "maven_max_file_size": 3221225472,
   "npm_max_file_size": 524288000,
   "nuget_max_file_size": 524288000,

doc/user/packages/helm_repository/index.md

@@ -18,24 +18,6 @@ packages whenever you need to use them as a dependency.
 For documentation of the specific API endpoints that Helm package manager
 clients use, see the [Helm API documentation](../../../api/packages/helm.md).
 
-## Enable the Helm repository feature
-
-Helm repository support is still a work in progress. It's gated behind a feature flag that's
-**disabled by default**. [GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md)
-can opt to enable it.
-
-To enable it:
-
-```ruby
-Feature.enable(:helm_packages)
-```
-
-To disable it:
-
-```ruby
-Feature.disable(:helm_packages)
-```
-
 ## Build a Helm package
 
 Creating a Helm package is documented [in the Helm documentation](https://helm.sh/docs/intro/using_helm/#creating-your-own-charts).
@@ -73,8 +55,16 @@ Once built, a chart can be uploaded to the `stable` channel with `curl` or `helm
 To install the latest version of a chart, use the following command:
 
 ```shell
-helm repo add project-1 https://gitlab.example.com/api/v4/projects/1/packages/helm/stable
+helm repo add --username <username> --password <personal_access_token> project-1 https://gitlab.example.com/api/v4/projects/1/packages/helm/stable
 helm install my-release project-1/mychart
 ```
 
+If the repo has previously been added, you may need to run:
+
+```shell
+helm repo update
+```
+
+To update the Helm client with the most currently available charts.
+
 See [Using Helm](https://helm.sh/docs/intro/using_helm/) for more information.

doc/user/packages/package_registry/index.md

@@ -35,7 +35,7 @@ For information on how to create and upload a package, view the GitLab documenta
 ## Use GitLab CI/CD to build packages
 
 You can use [GitLab CI/CD](../../../ci/index.md) to build packages.
-For Maven, NuGet, npm, Conan, and PyPI packages, and Composer dependencies, you can
+For Maven, NuGet, npm, Conan, Helm, and PyPI packages, and Composer dependencies, you can
 authenticate with GitLab by using the `CI_JOB_TOKEN`.
 
 CI/CD templates, which you can use to get started, are in [this repository](https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates).

lib/api/helm_packages.rb

@@ -29,10 +29,6 @@ module API
       require_packages_enabled!
     end
 
-    after_validation do
-      not_found! unless Feature.enabled?(:helm_packages, authorized_user_project)
-    end
-
     params do
       requires :id, type: String, desc: 'The ID or full path of a project'
     end