Ensure all scanners are translated in alerts

This slightly changes how the scanner names' translations are being
gathered before being passed to the security-scanner-alert component.
By moving all the translation to a shared map, it should harder to
forget to provide a new translation when adding a new scanner.

This is primarily done to translate SAST_IAC to something more
user-friendly.

Changelog: fixed

app/assets/javascripts/security_configuration/components/constants.js

@@ -22,6 +22,7 @@ import configureSecretDetectionMutation from '../graphql/configure_secret_detect
 
 /**
  * Translations & helpPagePaths for Security Configuration Page
+ * Make sure to add new scanner translations to the SCANNER_NAMES_MAP below.
  */
 
 export const SAST_NAME = __('Static Application Security Testing (SAST)');
@@ -138,6 +139,18 @@ export const LICENSE_COMPLIANCE_HELP_PATH = helpPagePath(
   'user/compliance/license_compliance/index',
 );
 
+export const SCANNER_NAMES_MAP = {
+  SAST: SAST_SHORT_NAME,
+  SAST_IAC: SAST_IAC_NAME,
+  DAST: DAST_SHORT_NAME,
+  API_FUZZING: API_FUZZING_NAME,
+  CONTAINER_SCANNING: CONTAINER_SCANNING_NAME,
+  CLUSTER_IMAGE_SCANNING: CLUSTER_IMAGE_SCANNING_NAME,
+  COVERAGE_FUZZING: COVERAGE_FUZZING_NAME,
+  SECRET_DETECTION: SECRET_DETECTION_NAME,
+  DEPENDENCY_SCANNING: DEPENDENCY_SCANNING_NAME,
+};
+
 export const securityFeatures = [
   {
     name: SAST_NAME,

ee/app/assets/javascripts/security_dashboard/components/project/project_vulnerabilities.vue

@@ -8,8 +8,8 @@ import vulnerabilitiesQuery from 'ee/security_dashboard/graphql/queries/project_
 import { preparePageInfo } from 'ee/security_dashboard/helpers';
 import { VULNERABILITIES_PER_PAGE } from 'ee/security_dashboard/store/constants';
 import { parseBoolean } from '~/lib/utils/common_utils';
-import { __, s__ } from '~/locale';
 import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
+import { SCANNER_NAMES_MAP } from '~/security_configuration/components/constants';
 import VulnerabilityList from '../shared/vulnerability_list.vue';
 import SecurityScannerAlert from './security_scanner_alert.vue';
 
@@ -92,8 +92,7 @@ export default {
       },
       update({ project = {} }) {
         const { available = [], enabled = [], pipelineRun = [] } = project?.securityScanners || {};
-        const translateScannerName = (scannerName) =>
-          this.$options.i18n[scannerName] || scannerName;
+        const translateScannerName = (scannerName) => SCANNER_NAMES_MAP[scannerName] || scannerName;
 
         return {
           available: available.map(translateScannerName),
@@ -164,14 +163,6 @@ export default {
     },
   },
   SCANNER_ALERT_DISMISSED_LOCAL_STORAGE_KEY: 'vulnerability_list_scanner_alert_dismissed',
-  i18n: {
-    API_FUZZING: __('API Fuzzing'),
-    CONTAINER_SCANNING: __('Container Scanning'),
-    CLUSTER_IMAGE_SCANNING: s__('ciReport|Cluster Image Scanning'),
-    COVERAGE_FUZZING: __('Coverage Fuzzing'),
-    SECRET_DETECTION: __('Secret Detection'),
-    DEPENDENCY_SCANNING: __('Dependency Scanning'),
-  },
 };
 </script>
 

ee/app/assets/javascripts/security_dashboard/components/project/project_vulnerability_report.vue

@@ -4,14 +4,7 @@ import { difference } from 'lodash';
 import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
 import { parseBoolean } from '~/lib/utils/common_utils';
-import {
-  API_FUZZING_NAME,
-  CLUSTER_IMAGE_SCANNING_NAME,
-  CONTAINER_SCANNING_NAME,
-  COVERAGE_FUZZING_NAME,
-  DEPENDENCY_SCANNING_NAME,
-  SECRET_DETECTION_NAME,
-} from '~/security_configuration/components/constants';
+import { SCANNER_NAMES_MAP } from '~/security_configuration/components/constants';
 import ReportNotConfiguredProject from '../shared/empty_states/report_not_configured_project.vue';
 import VulnerabilityReportTabs from '../shared/vulnerability_report/vulnerability_report_tabs.vue';
 import projectVulnerabilitiesQuery from '../../graphql/queries/project_vulnerabilities.query.graphql';
@@ -47,8 +40,7 @@ export default {
       },
       update({ project = {} }) {
         const { available = [], enabled = [], pipelineRun = [] } = project?.securityScanners || {};
-        const translateScannerName = (scannerName) =>
-          this.$options.i18n[scannerName] || scannerName;
+        const translateScannerName = (scannerName) => SCANNER_NAMES_MAP[scannerName] || scannerName;
 
         return {
           available: available.map(translateScannerName),
@@ -90,14 +82,6 @@ export default {
   projectVulnerabilitiesQuery,
   autoFixUserCalloutCookieName: 'auto_fix_user_callout_dismissed',
   SCANNER_ALERT_DISMISSED_LOCAL_STORAGE_KEY: 'vulnerability_list_scanner_alert_dismissed',
-  i18n: {
-    API_FUZZING: API_FUZZING_NAME,
-    CONTAINER_SCANNING: CONTAINER_SCANNING_NAME,
-    CLUSTER_IMAGE_SCANNING: CLUSTER_IMAGE_SCANNING_NAME,
-    COVERAGE_FUZZING: COVERAGE_FUZZING_NAME,
-    SECRET_DETECTION: SECRET_DETECTION_NAME,
-    DEPENDENCY_SCANNING: DEPENDENCY_SCANNING_NAME,
-  },
 };
 </script>
 

ee/spec/frontend/security_dashboard/components/project/project_vulnerabilities_spec.js

@@ -11,6 +11,7 @@ import { useLocalStorageSpy } from 'helpers/local_storage_helper';
 import createMockApollo from 'helpers/mock_apollo_helper';
 import waitForPromises from 'helpers/wait_for_promises';
 import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
+import { SCANNER_NAMES_MAP } from '~/security_configuration/components/constants';
 import { generateVulnerabilities } from '../mock_data';
 
 const localVue = createLocalVue();
@@ -286,6 +287,25 @@ describe('Vulnerabilities app component', () => {
       });
     });
 
+    describe.each(Object.keys(SCANNER_NAMES_MAP))(
+      'When %s is available but not enabled',
+      (scanner) => {
+        const translatedScannerName = SCANNER_NAMES_MAP[scanner];
+
+        beforeEach(() => {
+          createWrapperForScannerAlerts({
+            securityScanners: { available: [scanner], enabled: [], pipelineRun: [] },
+          });
+        });
+
+        it(`passes the translated scanner's name to the alert (${translatedScannerName})`, async () => {
+          expect(findSecurityScannerAlert().props('notEnabledScanners')[0]).toBe(
+            translatedScannerName,
+          );
+        });
+      },
+    );
+
     describe('dismissal', () => {
       beforeEach(() => {
         return createWrapperForScannerAlerts({

ee/spec/frontend/security_dashboard/components/project/project_vulnerability_report_spec.js

@@ -13,6 +13,7 @@ import AutoFixUserCallout from 'ee/security_dashboard/components/shared/auto_fix
 import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
 import { useLocalStorageSpy } from 'helpers/local_storage_helper';
 import createMockApollo from 'helpers/mock_apollo_helper';
+import { SCANNER_NAMES_MAP } from '~/security_configuration/components/constants';
 
 const localVue = createLocalVue();
 localVue.use(VueApollo);
@@ -141,6 +142,25 @@ describe('Project vulnerability report app component', () => {
         );
       });
     });
+
+    describe.each(Object.keys(SCANNER_NAMES_MAP))(
+      'When %s is available but not enabled',
+      (scanner) => {
+        const translatedScannerName = SCANNER_NAMES_MAP[scanner];
+
+        beforeEach(() => {
+          createWrapper({
+            securityScanners: { available: [scanner], enabled: [], pipelineRun: [] },
+          });
+        });
+
+        it(`passes the translated scanner's name to the alert (${translatedScannerName})`, async () => {
+          expect(findSecurityScannerAlert().props('notEnabledScanners')[0]).toBe(
+            translatedScannerName,
+          );
+        });
+      },
+    );
   });
 
   describe('auto fix user callout component', () => {