Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
76599631
Commit
76599631
authored
Sep 25, 2019
by
Andreas Brandl
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check migrations are reversible
parent
a716292f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
0 deletions
+2
-0
doc/development/database_review.md
doc/development/database_review.md
+2
-0
No files found.
doc/development/database_review.md
View file @
76599631
...
...
@@ -104,6 +104,8 @@ and details for a database reviewer:
place them in
`db/post_migrate`
instead of
`db/migrate`
. Keep in mind
that post migrations are executed post-deployment in production.
-
Check
[
timing guidelines for migrations
](
#timing-guidelines-for-migrations
)
-
Check migrations are reversible and implement a
`#down`
method
-
Data migrations should be reversible, too or come with a description of how to reverse.
-
Query performance
-
Check for any obviously complex queries and queries the author specifically
points out for review (if any)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment