Merge branch 'yamllint-docs-deprecations-removals' into 'master'

Run Yamllint for docs deprecations removals

See merge request gitlab-org/gitlab!81957

.gitlab/ci/rules.gitlab-ci.yml

@@ -167,6 +167,7 @@
 .yaml-lint-patterns: &yaml-lint-patterns
   - ".gitlab-ci.yml"
   - ".gitlab/ci/**/*.yml"
+  - "data/**/*.yml"
   - "lib/gitlab/ci/templates/**/*.yml"
 
 .docs-patterns: &docs-patterns

.gitlab/ci/yaml.gitlab-ci.yml

@@ -8,6 +8,6 @@ lint-yaml:
   stage: lint
   needs: []
   variables:
-    LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates
+    LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates data/deprecations data/removals data/whats_new
   script:
     - yamllint --strict -f colored $LINT_PATHS

data/deprecations/14-7-deprecate-merged_by-api-field.yml

@@ -19,7 +19,7 @@
   body: |  # Do not modify this line, instead modify the lines below.
     The `merged_by` field in the [merge request API](https://docs.gitlab.com/ee/api/merge_requests.html#list-merge-requests) is being deprecated and will be removed in GitLab 15.0. This field is being replaced with the `merge_user` field (already present in GraphQL) which more correctly identifies who merged a merge request when performing actions (merge when pipeline succeeds, add to merge train) other than a simple merge.
 # The following items are not published on the docs page, but may be used in the future.
-  stage:  create # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth
+  stage: create  # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth
   tiers:  # (optional - may be required in the future) An array of tiers that the feature is available in currently.  e.g., [Free, Silver, Gold, Core, Premium, Ultimate]
   issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/350534  # (optional) This is a link to the deprecation issue in GitLab
   documentation_url:  # (optional) This is a link to the current documentation page

data/deprecations/14-9-system_monitoring.yml

@@ -2,13 +2,13 @@
   announcement_milestone: "14.9"  # The milestone when this feature was first announced as deprecated.
   announcement_date: "2022-03-22"  # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
   removal_milestone: "15.0"  # The milestone when this feature is planned to be removed
-  removal_date: "2022-05-22" # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
+  removal_date: "2022-05-22"  # The date of the milestone release when this feature is planned to be removed. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
   breaking_change: true  # If this deprecation is a breaking change, set this value to true
   reporter: abellucci  # GitLab username of the person reporting the deprecation
   body: |  # Do not modify this line, instead modify the lines below.
     GitLab self-monitoring gives administrators of self-hosted GitLab instances the tools to monitor the health of their instances. This feature is deprecated in GitLab 14.9, and is scheduled for removal in 15.0.
 # The following items are not published on the docs page, but may be used in the future.
   stage: Monitor  # (optional - may be required in the future) String value of the stage that the feature was created in. e.g., Growth
-  tiers:  [Core, Premium, Ultimate] # (optional - may be required in the future) An array of tiers that the feature is available in currently.  e.g., [Free, Silver, Gold, Core, Premium, Ultimate]
-  issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/348909 # (optional) This is a link to the deprecation issue in GitLab
+  tiers: [Core, Premium, Ultimate]  # (optional - may be required in the future) An array of tiers that the feature is available in currently.  e.g., [Free, Silver, Gold, Core, Premium, Ultimate]
+  issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/348909  # (optional) This is a link to the deprecation issue in GitLab
   documentation_url: https://docs.gitlab.com/ee/administration/monitoring/gitlab_self_monitoring_project/  # (optional) This is a link to the current documentation page

data/deprecations/15-0-oauth.yml

@@ -3,7 +3,7 @@
   announcement_date: "2021-06-22"  # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
   removal_milestone: "15.0"  # The milestone when this feature is planned to be removed
   removal_date: "2022-05-22"  # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
-  breaking_change: yes # If this deprecation is a breaking change, set this value to true
+  breaking_change: true  # If this deprecation is a breaking change, set this value to true
   body: |  # Do not modify this line, instead modify the lines below.
     The OAuth implicit grant authorization flow will be removed in our next major release, GitLab 15.0. Any applications that use OAuth implicit grant should switch to alternative [supported OAuth flows](https://docs.gitlab.com/ee/api/oauth2.html).
 # The following items are not published on the docs page, but may be used in the future.

data/deprecations/distribution_deprecations_14-4.yml

-- name: "Move `custom_hooks_dir` setting from GitLab Shell to Gitaly" # The name of the feature to be deprecated
-  announcement_milestone: "14.9" # The milestone when this feature was first announced as deprecated.
+- name: "Move `custom_hooks_dir` setting from GitLab Shell to Gitaly"  # The name of the feature to be deprecated
+  announcement_milestone: "14.9"  # The milestone when this feature was first announced as deprecated.
   announcement_date: "2021-10-22"
-  removal_milestone: "15.0" # the milestone when this feature is planned to be removed
-  body: | # Do not modify this line, instead modify the lines below.
+  removal_milestone: "15.0"  # the milestone when this feature is planned to be removed
+  body: |  # Do not modify this line, instead modify the lines below.
     The [`custom_hooks_dir`](https://docs.gitlab.com/ee/administration/server_hooks.html#create-a-global-server-hook-for-all-repositories) setting is now configured in Gitaly, and will be removed from GitLab Shell in GitLab 15.0.