Merge branch 'ce-to-ee-2018-05-19' into 'master'

CE upstream - 2018-05-19 06:23 UTC

See merge request gitlab-org/gitlab-ee!5781

changelogs/unreleased/xeodon-gitlab-ce-fix-45743-master-fix-gitaly-delete-refs.yml

+---
+title: Fix error when deleting an empty list of refs
+merge_request:
+author:
+type: fixed

lib/gitlab/git/blob.rb

@@ -104,25 +104,22 @@ module Gitlab
         #       file.rb      # oid: 4a
         #
         #
-        # Blob.find_entry_by_path(repo, '1a', 'app/file.rb') # => '4a'
+        # Blob.find_entry_by_path(repo, '1a', 'blog', 'app', 'file.rb') # => '4a'
         #
-        def find_entry_by_path(repository, root_id, path)
+        def find_entry_by_path(repository, root_id, *path_parts)
           root_tree = repository.lookup(root_id)
-          # Strip leading slashes
-          path[%r{^/*}] = ''
-          path_arr = path.split('/')
 
           entry = root_tree.find do |entry|
-            entry[:name] == path_arr[0]
+            entry[:name] == path_parts[0]
           end
 
           return nil unless entry
 
-          if path_arr.size > 1
+          if path_parts.size > 1
             return nil unless entry[:type] == :tree
 
-            path_arr.shift
-            find_entry_by_path(repository, entry[:oid], path_arr.join('/'))
+            path_parts.shift
+            find_entry_by_path(repository, entry[:oid], *path_parts)
           else
             [:blob, :commit].include?(entry[:type]) ? entry : nil
           end
@@ -185,10 +182,13 @@ module Gitlab
         def find_by_rugged(repository, sha, path, limit:)
           return unless path
 
+          # Strip any leading / characters from the path
+          path = path.sub(%r{\A/*}, '')
+
           rugged_commit = repository.lookup(sha)
           root_tree = rugged_commit.tree
 
-          blob_entry = find_entry_by_path(repository, root_tree.oid, path)
+          blob_entry = find_entry_by_path(repository, root_tree.oid, *path.split('/'))
 
           return nil unless blob_entry
 

lib/gitlab/git/path_helper.rb

@@ -6,7 +6,7 @@ module Gitlab
       class << self
         def normalize_path(filename)
           # Strip all leading slashes so that //foo -> foo
-          filename[%r{^/*}] = ''
+          filename = filename.sub(%r{\A/*}, '')
 
           # Expand relative paths (e.g. foo/../bar)
           filename = Pathname.new(filename)

lib/gitlab/git/repository.rb

@@ -2381,7 +2381,7 @@ module Gitlab
       end
 
       def gitaly_delete_refs(*ref_names)
-        gitaly_ref_client.delete_refs(refs: ref_names)
+        gitaly_ref_client.delete_refs(refs: ref_names) if ref_names.any?
       end
 
       def rugged_remove_remote(remote_name)

spec/lib/gitlab/git/repository_spec.rb

@@ -600,6 +600,10 @@ describe Gitlab::Git::Repository, seed_helper: true do
         end
       end
 
+      it 'does not fail when deleting an empty list of refs' do
+        expect { repo.delete_refs(*[]) }.not_to raise_error
+      end
+
       it 'raises an error if it failed' do
         expect { repo.delete_refs('refs\heads\fix') }.to raise_error(Gitlab::Git::Repository::GitError)
       end