Merge branch 'fj-223731-update-snippet-statistics-on-project-import' into 'master'

Update snippet statistics after project import

See merge request gitlab-org/gitlab!35730

changelogs/unreleased/fj-223731-update-snippet-statistics-on-project-import.yml

+---
+title: Update snippet statistics after project import
+merge_request: 35730
+author:
+type: changed

lib/gitlab/import_export/snippet_repo_restorer.rb

@@ -42,6 +42,8 @@ module Gitlab
           snippet.repository.expire_exists_cache
 
           raise SnippetRepositoryError, _("Invalid repository bundle for snippet with id %{snippet_id}") % { snippet_id: snippet.id }
+        else
+          Snippets::UpdateStatisticsService.new(snippet).execute
         end
       end
 

spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb

@@ -35,6 +35,12 @@ RSpec.describe Gitlab::ImportExport::SnippetRepoRestorer do
       end
     end
 
+    it 'does not call snippet update statistics service' do
+      expect(Snippets::UpdateStatisticsService).not_to receive(:new).with(snippet)
+
+      restorer.restore
+    end
+
     context 'when the repository creation fails' do
       it 'returns false' do
         allow_any_instance_of(Gitlab::BackgroundMigration::BackfillSnippetRepositories).to receive(:perform_by_ids).and_return(nil)
@@ -66,6 +72,10 @@ RSpec.describe Gitlab::ImportExport::SnippetRepoRestorer do
 
     before do
       expect(exporter.save).to be_truthy
+
+      allow_next_instance_of(Snippets::RepositoryValidationService) do |instance|
+        allow(instance).to receive(:execute).and_return(ServiceResponse.success)
+      end
     end
 
     context 'when it is valid' do
@@ -115,5 +125,19 @@ RSpec.describe Gitlab::ImportExport::SnippetRepoRestorer do
         end
       end
     end
+
+    it 'refreshes snippet statistics' do
+      expect(snippet.statistics.commit_count).to be_zero
+      expect(snippet.statistics.file_count).to be_zero
+      expect(snippet.statistics.repository_size).to be_zero
+
+      expect(Snippets::UpdateStatisticsService).to receive(:new).with(snippet).and_call_original
+
+      restorer.restore
+
+      expect(snippet.statistics.commit_count).not_to be_zero
+      expect(snippet.statistics.file_count).not_to be_zero
+      expect(snippet.statistics.repository_size).not_to be_zero
+    end
   end
 end