Commit 77aa5d64 authored by Marc Shaw's avatar Marc Shaw

Remove the code_review_async_pipeline_creation feature flag

MR: gitlab.com/gitlab-org/gitlab/-/merge_requests/59624
Issue: gitlab.com/gitlab-org/gitlab/-/issues/327559
parent 59dd8a69
...@@ -162,12 +162,7 @@ module MergeRequests ...@@ -162,12 +162,7 @@ module MergeRequests
end end
def refresh_pipelines_on_merge_requests(merge_request) def refresh_pipelines_on_merge_requests(merge_request)
if Feature.enabled?(:code_review_async_pipeline_creation, project, default_enabled: :yaml) create_pipeline_for(merge_request, current_user, async: true)
create_pipeline_for(merge_request, current_user, async: true)
else
create_pipeline_for(merge_request, current_user, async: false)
UpdateHeadPipelineForMergeRequestWorker.perform_async(merge_request.id)
end
end end
def abort_auto_merges(merge_request) def abort_auto_merges(merge_request)
......
---
title: Create the merge request pipeline asynchronously on push
merge_request: 59624
author:
type: performance
---
name: code_review_async_pipeline_creation
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58542
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/327559
milestone: '13.11'
type: development
group: group::code review
default_enabled: false
...@@ -198,7 +198,7 @@ RSpec.describe MergeRequests::RefreshService do ...@@ -198,7 +198,7 @@ RSpec.describe MergeRequests::RefreshService do
end end
end end
shared_examples 'Pipelines for merge requests' do context 'Pipelines for merge requests', :sidekiq_inline do
before do before do
stub_ci_pipeline_yaml_file(config) stub_ci_pipeline_yaml_file(config)
end end
...@@ -364,18 +364,6 @@ RSpec.describe MergeRequests::RefreshService do ...@@ -364,18 +364,6 @@ RSpec.describe MergeRequests::RefreshService do
end end
end end
context 'when the code_review_async_pipeline_creation feature flag is on', :sidekiq_inline do
it_behaves_like 'Pipelines for merge requests'
end
context 'when the code_review_async_pipeline_creation feature flag is off', :sidekiq_inline do
before do
stub_feature_flags(code_review_async_pipeline_creation: false)
end
it_behaves_like 'Pipelines for merge requests'
end
context 'push to origin repo source branch' do context 'push to origin repo source branch' do
let(:refresh_service) { service.new(@project, @user) } let(:refresh_service) { service.new(@project, @user) }
let(:notification_service) { spy('notification_service') } let(:notification_service) { spy('notification_service') }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment