Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
77bd354c
Commit
77bd354c
authored
Oct 20, 2020
by
Amy Qualls
Committed by
Brandon Labuschagne
Oct 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update tooltip in config_toggle.js
Make my best guess at what's needed to update the tooltip.
parent
105dc62a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
ee/app/assets/javascripts/boards/config_toggle.js
ee/app/assets/javascripts/boards/config_toggle.js
+3
-3
ee/spec/features/boards/scoped_issue_board_spec.rb
ee/spec/features/boards/scoped_issue_board_spec.rb
+2
-2
No files found.
ee/app/assets/javascripts/boards/config_toggle.js
View file @
77bd354c
import
Vue
from
'
vue
'
;
import
tooltip
from
'
~/vue_shared/directives/tooltip
'
;
import
{
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
s__
,
__
}
from
'
~/locale
'
;
export
default
boardsStore
=>
{
...
...
@@ -9,7 +9,7 @@ export default boardsStore => {
gl
.
boardConfigToggle
=
new
Vue
({
el
:
configEl
,
directives
:
{
tooltip
,
GlTooltip
:
GlTooltipDirective
,
},
data
()
{
return
{
...
...
@@ -32,7 +32,7 @@ export default boardsStore => {
template
:
`
<div class="gl-ml-3">
<button
v-tooltip
v-
gl-
tooltip
:title="tooltipTitle"
class="btn btn-inverted"
:class="{ 'dot-highlight': hasScope }"
...
...
ee/spec/features/boards/scoped_issue_board_spec.rb
View file @
77bd354c
...
...
@@ -472,14 +472,14 @@ RSpec.describe 'Scoped issue boards', :js do
button
=
first
(
'.filter-dropdown-container .btn.btn-inverted'
)
expect
(
button
.
text
).
to
include
(
button_title
)
expect
(
button
[
:class
]).
to
include
(
'dot-highlight'
)
expect
(
button
[
'
data-original-
title'
]).
to
include
(
'This board\'s scope is reduced'
)
expect
(
button
[
'title'
]).
to
include
(
'This board\'s scope is reduced'
)
end
def
expect_no_dot_highlight
(
button_title
)
button
=
first
(
'.filter-dropdown-container .btn.btn-inverted'
)
expect
(
button
.
text
).
to
include
(
button_title
)
expect
(
button
[
:class
]).
not_to
include
(
'dot-highlight'
)
expect
(
button
[
'
data-original-
title'
]).
not_to
include
(
'This board\'s scope is reduced'
)
expect
(
button
[
'title'
]).
not_to
include
(
'This board\'s scope is reduced'
)
end
# Create board helper methods
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment