Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
789eb36c
Commit
789eb36c
authored
May 15, 2018
by
haseeb
Committed by
Rémy Coutable
May 15, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove authentication for readonly endpoints in issues API
parent
984e0f1a
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
189 additions
and
119 deletions
+189
-119
changelogs/unreleased/40855_remove_authentication_in_readonly_issue_api.yml
...sed/40855_remove_authentication_in_readonly_issue_api.yml
+5
-0
lib/api/issues.rb
lib/api/issues.rb
+2
-1
spec/requests/api/issues_spec.rb
spec/requests/api/issues_spec.rb
+182
-118
No files found.
changelogs/unreleased/40855_remove_authentication_in_readonly_issue_api.yml
0 → 100644
View file @
789eb36c
---
title
:
made listing and showing public issue apis available without authentication
merge_request
:
18638
author
:
haseebeqx
type
:
changed
lib/api/issues.rb
View file @
789eb36c
...
@@ -2,7 +2,7 @@ module API
...
@@ -2,7 +2,7 @@ module API
class
Issues
<
Grape
::
API
class
Issues
<
Grape
::
API
include
PaginationParams
include
PaginationParams
before
{
authenticate!
}
before
{
authenticate
_non_get
!
}
helpers
::
Gitlab
::
IssuableMetadata
helpers
::
Gitlab
::
IssuableMetadata
...
@@ -70,6 +70,7 @@ module API
...
@@ -70,6 +70,7 @@ module API
desc:
'Return issues for the given scope: `created-by-me`, `assigned-to-me` or `all`'
desc:
'Return issues for the given scope: `created-by-me`, `assigned-to-me` or `all`'
end
end
get
do
get
do
authenticate!
unless
params
[
:scope
]
==
'all'
issues
=
paginate
(
find_issues
)
issues
=
paginate
(
find_issues
)
options
=
{
options
=
{
...
...
spec/requests/api/issues_spec.rb
View file @
789eb36c
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment