Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
78cb222d
Commit
78cb222d
authored
Jun 19, 2019
by
egrieff
Committed by
Fatih Acet
Jun 24, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add bulk update endpoint for groups
parent
b74d846c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
44 additions
and
5 deletions
+44
-5
app/controllers/concerns/issuable_actions.rb
app/controllers/concerns/issuable_actions.rb
+1
-1
app/services/issuable/bulk_update_service.rb
app/services/issuable/bulk_update_service.rb
+5
-0
app/views/groups/issues.html.haml
app/views/groups/issues.html.haml
+2
-3
app/views/shared/issuable/_group_bulk_update_sidebar.html.haml
...iews/shared/issuable/_group_bulk_update_sidebar.html.haml
+19
-0
ee/app/controllers/concerns/ee/issuable_actions.rb
ee/app/controllers/concerns/ee/issuable_actions.rb
+6
-1
ee/app/controllers/groups/issues_controller.rb
ee/app/controllers/groups/issues_controller.rb
+5
-0
ee/config/routes/group.rb
ee/config/routes/group.rb
+6
-0
No files found.
app/controllers/concerns/issuable_actions.rb
View file @
78cb222d
...
...
@@ -92,7 +92,7 @@ module IssuableActions
end
def
bulk_update
result
=
Issuable
::
BulkUpdateService
.
new
(
p
rojec
t
,
current_user
,
bulk_update_params
).
execute
(
resource_name
)
result
=
Issuable
::
BulkUpdateService
.
new
(
p
aren
t
,
current_user
,
bulk_update_params
).
execute
(
resource_name
)
quantity
=
result
[
:count
]
render
json:
{
notice:
"
#{
quantity
}
#{
resource_name
.
pluralize
(
quantity
)
}
updated"
}
...
...
app/services/issuable/bulk_update_service.rb
View file @
78cb222d
# Language: Ruby, Level: Level 3
# frozen_string_literal: true
module
Issuable
class
BulkUpdateService
<
IssuableBaseService
def
initialize
(
parent
,
user
=
nil
,
params
=
{})
super
end
# rubocop: disable CodeReuse/ActiveRecord
def
execute
(
type
)
model_class
=
type
.
classify
.
constantize
...
...
app/views/groups/issues.html.haml
View file @
78cb222d
-
@project
=
@group
.
projects
.
first
-
@can_bulk_update
=
can?
(
current_user
,
:admin_issue
,
@project
)
-
@can_bulk_update
=
can?
(
current_user
,
:admin_issue
,
@group
)
-
page_title
"Issues"
=
content_for
:meta_tags
do
...
...
@@ -21,6 +20,6 @@
=
render
'shared/issuable/search_bar'
,
type: :issues
-
if
@can_bulk_update
=
render
'shared/issuable/bulk_update_sidebar'
,
type: :issues
=
render
'shared/issuable/
group_
bulk_update_sidebar'
,
type: :issues
=
render
'shared/issues'
app/views/shared/issuable/_group_bulk_update_sidebar.html.haml
0 → 100644
View file @
78cb222d
-
type
=
local_assigns
.
fetch
(
:type
)
-
@project
=
@group
.
projects
.
first
%aside
.issues-bulk-update.js-right-sidebar.right-sidebar
{
"aria-live"
=>
"polite"
,
data:
{
'signed-in'
:
current_user
.
present?
}
}
.issuable-sidebar.hidden
-# = form_tag [:bulk_update, @project.namespace.becomes(Namespace), @project, type], method: :post, class: "bulk-update" do
=
form_tag
bulk_update_group_issues_path
(
@group
),
method: :post
,
class:
"bulk-update"
do
.block.issuable-sidebar-header
.filter-item.inline.update-issues-btn.float-left
=
button_tag
"Update all"
,
class:
"btn update-selected-issues btn-info"
,
disabled:
true
=
button_tag
"Cancel"
,
class:
"btn btn-default js-bulk-update-menu-hide float-right"
.block
.title
Milestone
.filter-item
=
dropdown_tag
(
"Select milestone"
,
options:
{
title:
"Assign milestone"
,
toggle_class:
"js-milestone-select js-extra-options js-filter-submit js-filter-bulk-update"
,
filter:
true
,
dropdown_class:
"dropdown-menu-selectable dropdown-menu-milestone"
,
placeholder:
"Search milestones"
,
data:
{
show_no:
true
,
field_name:
"update[milestone_id]"
,
project_id:
@project
.
id
,
milestones:
project_milestones_path
(
@project
,
:json
),
use_id:
true
,
default_label:
"Milestone"
}
})
=
hidden_field_tag
"update[issuable_ids]"
,
[]
=
hidden_field_tag
:state_event
,
params
[
:state_event
]
ee/app/controllers/concerns/ee/issuable_actions.rb
View file @
78cb222d
...
...
@@ -6,9 +6,14 @@ module EE
extend
::
Gitlab
::
Utils
::
Override
EE_PERMITTED_KEYS
=
%w[
weight
weight
]
.
freeze
override
:authorize_admin_issuable!
def
authorize_admin_issuable!
return
access_denied!
unless
can?
(
current_user
,
:"admin_
#{
resource_name
}
"
,
parent
)
end
override
:permitted_keys
def
permitted_keys
@permitted_keys
||=
(
super
+
EE_PERMITTED_KEYS
).
freeze
...
...
ee/app/controllers/groups/issues_controller.rb
0 → 100644
View file @
78cb222d
# frozen_string_literal: true
class
Groups::IssuesController
<
Groups
::
ApplicationController
include
IssuableActions
end
ee/config/routes/group.rb
View file @
78cb222d
...
...
@@ -72,6 +72,12 @@ constraints(::Constraints::GroupUrlConstrainer.new) do
end
end
resources
:issues
,
only:
[]
do
collection
do
post
:bulk_update
end
end
resources
:todos
,
only:
[
:create
]
resources
:boards
,
only:
[
:create
,
:update
,
:destroy
]
do
collection
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment