Merge branch '271399-do-not-render-two-alerts-to-inform-project-is-locked' into 'master'

Do not render two alerts to inform project is locked

See merge request gitlab-org/gitlab!46239

ee/app/views/projects/_above_size_limit_warning.html.haml

 - size_checker = project.repository_size_checker
-- if size_checker.above_size_limit?
+- if size_checker.above_size_limit? && !project&.namespace&.additional_repo_storage_by_namespace_enabled?
   .gl-alert.gl-alert-warning.gl-display-none.gl-display-sm-block
     = sprite_icon('warning', css_class: 'gl-icon gl-alert-icon gl-alert-icon-no-title')
     = size_checker.error_message.above_size_limit_message

ee/spec/controllers/projects_controller_spec.rb

@@ -20,21 +20,42 @@ RSpec.describe ProjectsController do
 
     subject { get :show, params: { namespace_id: public_project.namespace.path, id: public_project.path } }
 
-    it 'shows the over size limit warning message if above_size_limit' do
-      allow_next_instance_of(Gitlab::RepositorySizeChecker) do |checker|
-        expect(checker).to receive(:above_size_limit?).and_return(true)
+    context 'with additional_repo_storage_by_namespace_enabled? enabled' do
+      before do
+        allow_any_instance_of(EE::Namespace).to receive(:additional_repo_storage_by_namespace_enabled?).and_return(true)
       end
-      allow(controller).to receive(:current_user).and_return(user)
 
-      subject
+      it 'does not show over size limit warning when above_size_limit' do
+        allow_next_instance_of(Gitlab::RepositorySizeChecker) do |checker|
+          expect(checker).to receive(:above_size_limit?).and_return(true)
+        end
+
+        subject
 
-      expect(response.body).to match(/The size of this repository.+exceeds the limit/)
+        expect(response.body).not_to match(/The size of this repository.+exceeds the limit/)
+      end
     end
 
-    it 'does not show an over size warning if not above_size_limit' do
-      subject
+    context 'with additional_repo_storage_by_namespace_enabled? disabled' do
+      before do
+        allow_any_instance_of(EE::Namespace).to receive(:additional_repo_storage_by_namespace_enabled?).and_return(false)
+      end
 
-      expect(response.body).not_to match(/The size of this repository.+exceeds the limit/)
+      it 'shows the over size limit warning message if above_size_limit' do
+        allow_next_instance_of(Gitlab::RepositorySizeChecker) do |checker|
+          expect(checker).to receive(:above_size_limit?).and_return(true)
+        end
+
+        subject
+
+        expect(response.body).to match(/The size of this repository.+exceeds the limit/)
+      end
+
+      it 'does not show an over size warning if not above_size_limit' do
+        subject
+
+        expect(response.body).not_to match(/The size of this repository.+exceeds the limit/)
+      end
     end
 
     context 'namespace storage limit' do