Commit 79f88652 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '328455-fix-admin-dashboard-version-check' into 'master'

Adjust spec for when GitLab version is not -pre

See merge request gitlab-org/gitlab!59806
parents 0a9c715f 212fef21
...@@ -4,6 +4,7 @@ require 'spec_helper' ...@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe 'admin/dashboard/index.html.haml' do RSpec.describe 'admin/dashboard/index.html.haml' do
include Devise::Test::ControllerHelpers include Devise::Test::ControllerHelpers
include StubVersion
before do before do
counts = Admin::DashboardController::COUNTED_ITEMS.each_with_object({}) do |item, hash| counts = Admin::DashboardController::COUNTED_ITEMS.each_with_object({}) do |item, hash|
...@@ -26,10 +27,21 @@ RSpec.describe 'admin/dashboard/index.html.haml' do ...@@ -26,10 +27,21 @@ RSpec.describe 'admin/dashboard/index.html.haml' do
expect(rendered).to have_content Gitlab::Workhorse.version expect(rendered).to have_content Gitlab::Workhorse.version
end end
it "includes revision of GitLab" do it "includes revision of GitLab for pre VERSION" do
stub_version('13.11.0-pre', 'abcdefg')
render
expect(rendered).to have_content "13.11.0-pre abcdefg"
end
it 'shows the tag for GitLab version' do
stub_version('13.11.0', 'abcdefg')
render render
expect(rendered).to have_content "#{Gitlab::VERSION} #{Gitlab.revision}" expect(rendered).to have_content "13.11.0"
expect(rendered).not_to have_content "abcdefg"
end end
it 'does not include license breakdown' do it 'does not include license breakdown' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment