Use finding factory instead of manual changes

ee/spec/services/ee/issues/create_from_vulnerability_service_spec.rb

@@ -36,13 +36,7 @@ RSpec.describe Issues::CreateFromVulnerabilityService, '#execute' do
       let(:vulnerability) { create(:vulnerability, :with_remediation, project: project) }
 
       context 'when raw_metadata has no remediations' do
-        before do
-          finding = vulnerability.finding
-          metadata = Gitlab::Json.parse(finding.raw_metadata)
-          metadata.delete("remediations")
-          finding.raw_metadata = metadata.to_json
-          finding.save!
-        end
+        let(:vulnerability) { create(:vulnerability, :with_finding, project: project) }
 
         it 'does not display Remediations section' do
           expect(vulnerability.remediations).to eq(nil)