Commit 7a2f033b authored by Sean McGivern's avatar Sean McGivern

Merge branch 'cleanup_project_level_issues_analytics_ff' into 'master'

Remove project_level_issues_analytics FF

See merge request gitlab-org/gitlab!71382
parents cae15220 deba920f
---
name: project_level_issues_analytics
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/25417
rollout_issue_url:
milestone: '12.9'
type: development
group: group::optimize
default_enabled: true
...@@ -65,8 +65,7 @@ module EE ...@@ -65,8 +65,7 @@ module EE
end end
def show_issues_analytics? def show_issues_analytics?
::Feature.enabled?(:project_level_issues_analytics, context.project, default_enabled: true) && context.project.licensed_feature_available?(:issues_analytics) &&
context.project.licensed_feature_available?(:issues_analytics) &&
can?(context.current_user, :read_project, context.project) can?(context.current_user, :read_project, context.project)
end end
......
...@@ -50,10 +50,10 @@ RSpec.describe Sidebars::Projects::Menus::AnalyticsMenu do ...@@ -50,10 +50,10 @@ RSpec.describe Sidebars::Projects::Menus::AnalyticsMenu do
describe 'Issue' do describe 'Issue' do
let(:item_id) { :issues } let(:item_id) { :issues }
let(:flag_enabled) { true } let(:licensed) { true }
before do before do
stub_licensed_features(issues_analytics: flag_enabled) stub_licensed_features(issues_analytics: licensed)
end end
specify { is_expected.not_to be_nil } specify { is_expected.not_to be_nil }
...@@ -64,16 +64,8 @@ RSpec.describe Sidebars::Projects::Menus::AnalyticsMenu do ...@@ -64,16 +64,8 @@ RSpec.describe Sidebars::Projects::Menus::AnalyticsMenu do
specify { is_expected.to be_nil } specify { is_expected.to be_nil }
end end
describe 'when feature flag :project_level_issues_analytics is not enabled' do
before do
stub_feature_flags(project_level_issues_analytics: false)
end
specify { is_expected.to be_nil }
end
describe 'when licensed feature issues analytics is not enabled' do describe 'when licensed feature issues analytics is not enabled' do
let(:flag_enabled) { false } let(:licensed) { false }
specify { is_expected.to be_nil } specify { is_expected.to be_nil }
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment