Merge branch 'fj-228686-improve-time-spec-feature-public-access-spec' into 'master'

Improving execution time for snippet feature spec public_access

See merge request gitlab-org/gitlab!36938

ee/spec/features/security/project/snippet/public_access_spec.rb

@@ -5,11 +5,10 @@ require 'spec_helper'
 RSpec.describe "Public Project Snippets Access" do
   include AccessMatchers
 
-  let(:project) { create(:project, :public) }
-
-  let(:public_snippet)   { create(:project_snippet, :public,   project: project, author: project.owner) }
-  let(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
-  let(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
+  let_it_be(:project) { create(:project, :public) }
+  let_it_be(:public_snippet)   { create(:project_snippet, :public,   project: project, author: project.owner) }
+  let_it_be(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
+  let_it_be(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
 
   describe "GET /:project_path/snippets" do
     subject { project_snippets_path(project) }

spec/features/security/project/snippet/public_access_spec.rb

@@ -5,11 +5,10 @@ require 'spec_helper'
 RSpec.describe "Public Project Snippets Access" do
   include AccessMatchers
 
-  let(:project) { create(:project, :public) }
-
-  let(:public_snippet)   { create(:project_snippet, :public,   project: project, author: project.owner) }
-  let(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
-  let(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
+  let_it_be(:project) { create(:project, :public) }
+  let_it_be(:public_snippet)   { create(:project_snippet, :public,   project: project, author: project.owner) }
+  let_it_be(:internal_snippet) { create(:project_snippet, :internal, project: project, author: project.owner) }
+  let_it_be(:private_snippet)  { create(:project_snippet, :private,  project: project, author: project.owner) }
 
   describe "GET /:project_path/snippets" do
     subject { project_snippets_path(project) }