Merge branch...

Merge branch '339281-remove-rubocop-rule-preventing-indexes-from-being-added-to-tables-ci_builds_metadata-events' into 'master'

Resolve "Remove rubocop rule preventing indexes from being added to tables: ci_builds_metadata, events, taggings"

See merge request gitlab-org/gitlab!70050

rubocop/cop/migration/prevent_index_creation.rb

@@ -8,7 +8,7 @@ module RuboCop
       class PreventIndexCreation < RuboCop::Cop::Cop
         include MigrationHelpers
 
-        FORBIDDEN_TABLES = %i[ci_builds taggings ci_builds_metadata events].freeze
+        FORBIDDEN_TABLES = %i[ci_builds].freeze
 
         MSG = "Adding new index to #{FORBIDDEN_TABLES.join(", ")} is forbidden, see https://gitlab.com/gitlab-org/gitlab/-/issues/332886"
 

spec/rubocop/cop/migration/prevent_index_creation_spec.rb

@@ -6,7 +6,7 @@ require_relative '../../../../rubocop/cop/migration/prevent_index_creation'
 RSpec.describe RuboCop::Cop::Migration::PreventIndexCreation do
   subject(:cop) { described_class.new }
 
-  let(:forbidden_tables) { %w(ci_builds taggings ci_builds_metadata events) }
+  let(:forbidden_tables) { %w(ci_builds) }
   let(:forbidden_tables_list) { forbidden_tables.join(', ') }
 
   context 'when in migration' do