Merge branch 'rails-save-bang-ee-spec-presenters' into 'master'

Fix Rails/SaveBang offenses in ee/spec/presenters

See merge request gitlab-org/gitlab!58082

.rubocop_manual_todo.yml

@@ -99,8 +99,6 @@ Rails/SaveBang:
     - 'ee/spec/models/visible_approvable_spec.rb'
     - 'ee/spec/models/vulnerabilities/feedback_spec.rb'
     - 'ee/spec/models/vulnerabilities/issue_link_spec.rb'
-    - 'ee/spec/presenters/audit_event_presenter_spec.rb'
-    - 'ee/spec/presenters/epic_presenter_spec.rb'
     - 'ee/spec/requests/api/boards_spec.rb'
     - 'ee/spec/requests/api/epic_issues_spec.rb'
     - 'ee/spec/requests/api/epic_links_spec.rb'

ee/changelogs/unreleased/rails-save-bang-ee-spec-presenter.yml

+---
+title: Fix Rails/SaveBang rubocop offenses in ee/spec/presenters
+merge_request: 58082
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/presenters/audit_event_presenter_spec.rb

@@ -40,7 +40,7 @@ RSpec.describe AuditEventPresenter do
       let(:audit_event) { create(:audit_event, user: user, details: details) }
 
       before do
-        user.destroy
+        user.destroy!
         audit_event.reload
       end
 

ee/spec/presenters/epic_presenter_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe EpicPresenter do
     let(:milestone2) { create(:milestone, title: 'make me a pizza', start_date: '2020-01-01', due_date: '2029-12-31') }
 
     before do
-      epic.update(
+      epic.update!(
         start_date_sourcing_milestone: milestone1, start_date: Date.new(2000, 1, 1),
         due_date_sourcing_milestone: milestone2, due_date: Date.new(2000, 1, 2)
       )