Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7d4b2349
Commit
7d4b2349
authored
Feb 24, 2022
by
Eugie Limpin
Committed by
Kati Paizee
Feb 24, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Document issue encountered with request caching of broadcast messages
parent
b640376c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
0 deletions
+7
-0
doc/development/caching.md
doc/development/caching.md
+7
-0
No files found.
doc/development/caching.md
View file @
7d4b2349
...
...
@@ -265,6 +265,13 @@ All the time!
-
As the lookup is similar to a cache lookup (in the GitLab implementation), we can use
the same key for both. This is how
`Gitlab::Cache.fetch_once`
works.
#### Possible downsides
-
Adding new attributes to a cached object using
`Gitlab::JsonCache`
and
`Gitlab::SafeRequestStore`
, for example, can lead to stale data issues
where the cache data doesn't have the appropriate value for the new attribute
(see this past
[
incident
](
https://gitlab.com/gitlab-com/gl-infra/production/-/issues/6372
)
).
### When to use SQL caching
Rails uses this automatically for identical queries in a request, so no action is
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment