Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-dora' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/dora

See merge request gitlab-org/gitlab!58353

.rubocop_manual_todo.yml

@@ -503,7 +503,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/services/dast_scanner_profiles/destroy_service_spec.rb
     - ee/spec/services/dast_scanner_profiles/update_service_spec.rb
     - ee/spec/services/dast_site_profiles/destroy_service_spec.rb
-    - ee/spec/services/dora/aggregate_metrics_service_spec.rb
     - ee/spec/services/external_approval_rules/create_service_spec.rb
     - ee/spec/services/external_approval_rules/destroy_service_spec.rb
     - ee/spec/services/external_approval_rules/update_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-dora.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/dora
+merge_request: 58353
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/services/dora/aggregate_metrics_service_spec.rb

@@ -93,6 +93,7 @@ RSpec.describe Dora::AggregateMetricsService do
       let_it_be(:staging) { create(:environment, :staging, project: project) }
       let_it_be(:maintainer) { create(:user) }
       let_it_be(:guest) { create(:user) }
+
       let(:container) { project }
       let(:user) { maintainer }
       let(:params) { { metric: 'deployment_frequency' }.merge(extra_params) }
@@ -153,6 +154,7 @@ RSpec.describe Dora::AggregateMetricsService do
       let_it_be(:production_2) { create(:environment, :production, project: project_2) }
       let_it_be(:maintainer) { create(:user) }
       let_it_be(:guest) { create(:user) }
+
       let(:container) { group }
       let(:user) { maintainer }
       let(:params) { { metric: 'deployment_frequency' }.merge(extra_params) }