Commit 7e1ccb5c authored by Robert Speicher's avatar Robert Speicher Committed by Rémy Coutable

Merge branch 'improve-award-emoji-spinach-tests' into 'master'

Improve award emoji test reliability by checking that the emoji is displayed before the search field is focused

See merge request !3288
parent 51a4c597
...@@ -18,21 +18,24 @@ Feature: Award Emoji ...@@ -18,21 +18,24 @@ Feature: Award Emoji
@javascript @javascript
Scenario: I add and remove custom award in the issue Scenario: I add and remove custom award in the issue
Given I click to emoji-picker Given I click to emoji-picker
Then The search field is focused Then The emoji menu is visible
And I click to emoji in the picker And The search field is focused
Then I click to emoji in the picker
Then I have award added Then I have award added
And I can remove it by clicking to icon And I can remove it by clicking to icon
@javascript @javascript
Scenario: I can see the list of emoji categories Scenario: I can see the list of emoji categories
Given I click to emoji-picker Given I click to emoji-picker
Then The search field is focused Then The emoji menu is visible
And The search field is focused
Then I can see the activity and food categories Then I can see the activity and food categories
@javascript @javascript
Scenario: I can search emoji Scenario: I can search emoji
Given I click to emoji-picker Given I click to emoji-picker
Then The search field is focused Then The emoji menu is visible
And The search field is focused
And I search "hand" And I search "hand"
Then I see search result for "hand" Then I see search result for "hand"
......
...@@ -92,6 +92,10 @@ class Spinach::Features::AwardEmoji < Spinach::FeatureSteps ...@@ -92,6 +92,10 @@ class Spinach::Features::AwardEmoji < Spinach::FeatureSteps
end end
end end
step 'The emoji menu is visible' do
page.find(".emoji-menu.is-visible")
end
step 'The search field is focused' do step 'The search field is focused' do
expect(page).to have_selector('#emoji_search') expect(page).to have_selector('#emoji_search')
expect(page.evaluate_script('document.activeElement.id')).to eq('emoji_search') expect(page.evaluate_script('document.activeElement.id')).to eq('emoji_search')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment