Commit 7ee20cb9 authored by Thong Kuah's avatar Thong Kuah

Merge branch 'remove-dedupe-instances-feature-flag' into 'master'

Rollout Deploy Board Duplicate Instances Fix to Self-Managed

See merge request gitlab-org/gitlab!46374
parents 18cbc266 264a850a
---
name: deploy_boards_dedupe_instances
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40768
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/258214
type: development
group: group::progressive delivery
default_enabled: false
...@@ -41,9 +41,9 @@ knowledge. In particular, you should be familiar with: ...@@ -41,9 +41,9 @@ knowledge. In particular, you should be familiar with:
- [Kubernetes namespaces](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/) - [Kubernetes namespaces](https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/)
- [Kubernetes canary deployments](https://kubernetes.io/docs/concepts/cluster-administration/manage-deployment/#canary-deployments) - [Kubernetes canary deployments](https://kubernetes.io/docs/concepts/cluster-administration/manage-deployment/#canary-deployments)
NOTE: **Note:** In GitLab 13.5 and earlier, apps that consist of multiple deployments are shown as
Apps that consist of multiple deployments are shown as duplicates on the deploy board. duplicates on the deploy board. This is [fixed](https://gitlab.com/gitlab-org/gitlab/-/issues/8463)
Follow [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/8463) for details. in GitLab 13.6.
## Use cases ## Use cases
......
---
title: Fix duplicate instances in deploy boards when multiple deployments have the same track
merge_request: 46374
author:
type: fixed
...@@ -54,13 +54,7 @@ module Gitlab ...@@ -54,13 +54,7 @@ module Gitlab
def initialize(deployments, pods: [], ingresses: [], status: :found) def initialize(deployments, pods: [], ingresses: [], status: :found)
@status = status @status = status
@deployments = deployments @deployments = deployments
@instances = RolloutInstances.new(deployments, pods).pod_instances
@instances = if ::Feature.enabled?(:deploy_boards_dedupe_instances)
RolloutInstances.new(deployments, pods).pod_instances
else
deployments.flat_map(&:instances)
end
@canary_ingress = ingresses.find(&:canary?) @canary_ingress = ingresses.find(&:canary?)
@completion = @completion =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment