Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7f0f752a
Commit
7f0f752a
authored
Mar 11, 2019
by
walkafwalka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use project name and id in review app url instead of project path slug
parent
e1707413
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
4 deletions
+9
-4
changelogs/unreleased/fix-review-app-env-url.yml
changelogs/unreleased/fix-review-app-env-url.yml
+5
-0
doc/topics/autodevops/index.md
doc/topics/autodevops/index.md
+3
-3
lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml
lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml
+1
-1
No files found.
changelogs/unreleased/fix-review-app-env-url.yml
0 → 100644
View file @
7f0f752a
---
title
:
Fixes long review app subdomains
merge_request
:
25990
author
:
walkafwalka
type
:
fixed
doc/topics/autodevops/index.md
View file @
7f0f752a
...
...
@@ -442,10 +442,10 @@ process. Auto Review Apps create a Review App for each branch.
Auto Review Apps will deploy your app to your Kubernetes cluster only. When no cluster
is available, no deployment will occur.
The Review App will have a unique URL based on the project
name, the branch
The Review App will have a unique URL based on the project
ID, the branch or tag
name, and a unique number, combined with the Auto DevOps base domain. For
example,
`
user-project-branch-1234
.example.com`
. A link to the Review App shows
up in the merge request widget for easy discovery. When the branch is deleted,
example,
`
13083-review-project-branch-123456
.example.com`
. A link to the Review App shows
up in the merge request widget for easy discovery. When the branch
or tag
is deleted,
for example after the merge request is merged, the Review App will automatically
be deleted.
...
...
lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml
View file @
7f0f752a
...
...
@@ -262,7 +262,7 @@ review:
-
persist_environment_url
environment
:
name
:
review/$CI_COMMIT_REF_NAME
url
:
http://$CI_PROJECT_
PATH_SLUG
-$CI_ENVIRONMENT_SLUG.$KUBE_INGRESS_BASE_DOMAIN
url
:
http://$CI_PROJECT_
ID
-$CI_ENVIRONMENT_SLUG.$KUBE_INGRESS_BASE_DOMAIN
on_stop
:
stop_review
artifacts
:
paths
:
[
environment_url.txt
]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment