Merge branch '2762-ldap-group-link-select-dropdown-error' into 'master'

Resolve "LDAP group link select dropdown error"

Closes #2762

See merge request !2277

app/assets/javascripts/api.js

@@ -172,8 +172,7 @@ const Api = {
         active: true,
       }),
       dataType: 'json',
-    })
-      .done(groups => callback(groups));
+    }).then(groups => callback(groups));
   },
 
   buildUrl(url) {

spec/javascripts/api_spec.js

@@ -278,4 +278,21 @@ describe('Api', () => {
         .catch(done.fail);
     });
   });
+
+  describe('ldap_groups', () => {
+    it('calls callback on completion', (done) => {
+      const query = 'query';
+      const provider = 'provider';
+      const callback = jasmine.createSpy();
+
+      spyOn(jQuery, 'ajax').and.callFake(() => $.Deferred().resolve());
+
+      Api.ldap_groups(query, provider, callback)
+        .then((response) => {
+          expect(callback).toHaveBeenCalledWith(response);
+        })
+        .then(done)
+        .catch(done.fail);
+    });
+  });
 });