Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8034db53
Commit
8034db53
authored
Apr 14, 2021
by
Dheeraj Joshi
Committed by
Natalia Tepluhina
Apr 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert: Enable submit by default in DAST Scanner Profile
parent
1d348115
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
9 deletions
+4
-9
ee/app/assets/javascripts/security_configuration/dast_scanner_profiles/components/dast_scanner_profile_form.vue
...scanner_profiles/components/dast_scanner_profile_form.vue
+1
-1
ee/changelogs/unreleased/djadmin-scanner-profile-composable.yml
...ngelogs/unreleased/djadmin-scanner-profile-composable.yml
+0
-5
ee/spec/frontend/security_configuration/dast_scanner_profiles_form/components/dast_scanner_profiles_form_spec.js
...ofiles_form/components/dast_scanner_profiles_form_spec.js
+3
-3
No files found.
ee/app/assets/javascripts/security_configuration/dast_scanner_profiles/components/dast_scanner_profile_form.vue
View file @
8034db53
...
...
@@ -141,7 +141,7 @@ export default {
);
},
isSubmitDisabled
()
{
return
this
.
isPolicyProfile
;
return
this
.
formHasErrors
||
this
.
requiredFieldEmpty
||
this
.
isPolicyProfile
;
},
isPolicyProfile
()
{
return
Boolean
(
this
.
profile
?.
referencedInSecurityPolicies
?.
length
);
...
...
ee/changelogs/unreleased/djadmin-scanner-profile-composable.yml
deleted
100644 → 0
View file @
1d348115
---
title
:
Always display submit button for DAST Scanner Profile form
merge_request
:
56928
author
:
type
:
changed
ee/spec/frontend/security_configuration/dast_scanner_profiles_form/components/dast_scanner_profiles_form_spec.js
View file @
8034db53
...
...
@@ -94,18 +94,18 @@ describe('DAST Scanner Profile', () => {
createComponent
();
});
describe
(
'
is
enabled even
if
'
,
()
=>
{
describe
(
'
is
disabled
if
'
,
()
=>
{
it
(
'
form contains errors
'
,
async
()
=>
{
findProfileNameInput
().
vm
.
$emit
(
'
input
'
,
profileName
);
await
findSpiderTimeoutInput
().
vm
.
$emit
(
'
input
'
,
'
12312
'
);
expect
(
findSubmitButton
().
props
(
'
disabled
'
)).
toBe
(
fals
e
);
expect
(
findSubmitButton
().
props
(
'
disabled
'
)).
toBe
(
tru
e
);
});
it
(
'
at least one field is empty
'
,
async
()
=>
{
findProfileNameInput
().
vm
.
$emit
(
'
input
'
,
''
);
await
findSpiderTimeoutInput
().
vm
.
$emit
(
'
input
'
,
spiderTimeout
);
await
findTargetTimeoutInput
().
vm
.
$emit
(
'
input
'
,
targetTimeout
);
expect
(
findSubmitButton
().
props
(
'
disabled
'
)).
toBe
(
fals
e
);
expect
(
findSubmitButton
().
props
(
'
disabled
'
)).
toBe
(
tru
e
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment