Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8179e0fe
Commit
8179e0fe
authored
Nov 19, 2021
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve skipped billing page hand raise spec
parent
158e643f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
10 deletions
+17
-10
ee/app/assets/javascripts/hand_raise_leads/hand_raise_lead/components/hand_raise_lead_button.vue
...ads/hand_raise_lead/components/hand_raise_lead_button.vue
+7
-7
ee/spec/features/billings/billing_plans_spec.rb
ee/spec/features/billings/billing_plans_spec.rb
+10
-3
No files found.
ee/app/assets/javascripts/hand_raise_leads/hand_raise_lead/components/hand_raise_lead_button.vue
View file @
8179e0fe
...
@@ -210,11 +210,11 @@ export default {
...
@@ -210,11 +210,11 @@ export default {
<gl-form-group
<gl-form-group
:label=
"$options.i18n.firstNameLabel"
:label=
"$options.i18n.firstNameLabel"
label-size=
"sm"
label-size=
"sm"
label-for=
"first
N
ame"
label-for=
"first
-n
ame"
class=
"mr-3 w-50"
class=
"mr-3 w-50"
>
>
<gl-form-input
<gl-form-input
id=
"first-
N
ame"
id=
"first-
n
ame"
v-model=
"firstName"
v-model=
"firstName"
type=
"text"
type=
"text"
class=
"form-control"
class=
"form-control"
...
@@ -224,11 +224,11 @@ export default {
...
@@ -224,11 +224,11 @@ export default {
<gl-form-group
<gl-form-group
:label=
"$options.i18n.lastNameLabel"
:label=
"$options.i18n.lastNameLabel"
label-size=
"sm"
label-size=
"sm"
label-for=
"last
N
ame"
label-for=
"last
-n
ame"
class=
"w-50"
class=
"w-50"
>
>
<gl-form-input
<gl-form-input
id=
"last-
N
ame"
id=
"last-
n
ame"
v-model=
"lastName"
v-model=
"lastName"
type=
"text"
type=
"text"
class=
"form-control"
class=
"form-control"
...
@@ -240,7 +240,7 @@ export default {
...
@@ -240,7 +240,7 @@ export default {
<gl-form-group
<gl-form-group
:label=
"$options.i18n.companyNameLabel"
:label=
"$options.i18n.companyNameLabel"
label-size=
"sm"
label-size=
"sm"
label-for=
"company
N
ame"
label-for=
"company
-n
ame"
class=
"mr-3 w-50"
class=
"mr-3 w-50"
>
>
<gl-form-input
<gl-form-input
...
@@ -254,7 +254,7 @@ export default {
...
@@ -254,7 +254,7 @@ export default {
<gl-form-group
<gl-form-group
:label=
"$options.i18n.companySizeLabel"
:label=
"$options.i18n.companySizeLabel"
label-size=
"sm"
label-size=
"sm"
label-for=
"company
S
ize"
label-for=
"company
-s
ize"
class=
"w-50"
class=
"w-50"
>
>
<gl-form-select
<gl-form-select
...
@@ -271,7 +271,7 @@ export default {
...
@@ -271,7 +271,7 @@ export default {
:label=
"$options.i18n.phoneNumberLabel"
:label=
"$options.i18n.phoneNumberLabel"
label-size=
"sm"
label-size=
"sm"
:description=
"$options.i18n.phoneNumberDescription"
:description=
"$options.i18n.phoneNumberDescription"
label-for=
"phone
N
umber"
label-for=
"phone
-n
umber"
>
>
<gl-form-input
<gl-form-input
id=
"phone-number"
id=
"phone-number"
...
...
ee/spec/features/billings/billing_plans_spec.rb
View file @
8179e0fe
...
@@ -5,7 +5,7 @@ require 'spec_helper'
...
@@ -5,7 +5,7 @@ require 'spec_helper'
RSpec
.
describe
'Billing plan pages'
,
:feature
,
:js
do
RSpec
.
describe
'Billing plan pages'
,
:feature
,
:js
do
include
SubscriptionPortalHelpers
include
SubscriptionPortalHelpers
let
(
:user
)
{
create
(
:user
)
}
let
(
:user
)
{
create
(
:user
,
first_name:
'James'
,
last_name:
'Bond'
,
organization:
'ACME'
)
}
let
(
:namespace
)
{
user
.
namespace
}
let
(
:namespace
)
{
user
.
namespace
}
let
(
:free_plan
)
{
create
(
:free_plan
)
}
let
(
:free_plan
)
{
create
(
:free_plan
)
}
let
(
:bronze_plan
)
{
create
(
:bronze_plan
)
}
let
(
:bronze_plan
)
{
create
(
:bronze_plan
)
}
...
@@ -86,8 +86,15 @@ RSpec.describe 'Billing plan pages', :feature, :js do
...
@@ -86,8 +86,15 @@ RSpec.describe 'Billing plan pages', :feature, :js do
end
end
it
'displays the in-app hand raise lead'
do
it
'displays the in-app hand raise lead'
do
skip
"not supported for
#{
plan
.
name
}
"
if
plan
.
name
==
'bronze'
if
namespace
.
group_namespace?
page
.
within
(
'.content'
)
do
page
.
within
(
'[data-testid="plan-card-premium"]'
)
do
click_button
'Contact sales'
end
expect
(
page
).
to
have_content
(
'Contact our Sales team'
)
expect
(
page
).
to
have_field
(
'First Name'
,
with:
'James'
)
expect
(
page
).
to
have_field
(
'Last Name'
,
with:
'Bond'
)
expect
(
page
).
to
have_field
(
'Company Name'
,
with:
'ACME'
)
else
expect
(
page
).
to
have_selector
(
".js-hand-raise-lead-button[data-namespace-id='
#{
namespace
.
id
}
'][data-user-name='
#{
user
.
username
}
']"
,
visible:
false
)
expect
(
page
).
to
have_selector
(
".js-hand-raise-lead-button[data-namespace-id='
#{
namespace
.
id
}
'][data-user-name='
#{
user
.
username
}
']"
,
visible:
false
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment