Merge branch '332400-remove-metrics-report-usage-data-feature-flag' into 'master'

[RUN AS-IF-FOSS] [RUN ALL RSPEC] Remove metrics report usage data feature flag

See merge request gitlab-org/gitlab!68657

config/feature_flags/development/usage_data_i_testing_metrics_report_widget_total.yml

----
-name: usage_data_i_testing_metrics_report_widget_total
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50790
-rollout_issue_url:
-milestone: '13.8'
-type: development
-group: group::testing
-default_enabled: true

ee/app/assets/javascripts/vue_shared/metrics_reports/grouped_metrics_reports_app.vue

@@ -7,7 +7,6 @@ import { n__, s__, sprintf } from '~/locale';
 import ReportItem from '~/reports/components/report_item.vue';
 import ReportSection from '~/reports/components/report_section.vue';
 import SmartVirtualList from '~/vue_shared/components/smart_virtual_list.vue';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import createStore from './store';
 
 export default {
@@ -18,7 +17,6 @@ export default {
     ReportItem,
     SmartVirtualList,
   },
-  mixins: [glFeatureFlagsMixin()],
   props: {
     endpoint: {
       type: String,
@@ -65,9 +63,7 @@ export default {
     },
     handleToggleEvent() {
       return once(() => {
-        if (this.glFeatures.usageDataITestingMetricsReportWidgetTotal) {
-          api.trackRedisHllUserEvent(this.$options.expandEvent);
-        }
+        api.trackRedisHllUserEvent(this.$options.expandEvent);
       });
     },
   },

ee/app/controllers/ee/projects/merge_requests_controller.rb

@@ -11,7 +11,6 @@ module EE
         before_action only: [:show] do
           push_frontend_feature_flag(:anonymous_visual_review_feedback)
           push_frontend_feature_flag(:missing_mr_security_scan_types, @project)
-          push_frontend_feature_flag(:usage_data_i_testing_metrics_report_widget_total, @project, default_enabled: true)
           push_frontend_feature_flag(:usage_data_i_testing_load_performance_widget_total, @project, default_enabled: true)
         end
 

ee/spec/frontend/vue_shared/metrics_reports/grouped_metrics_reports_app_spec.js

@@ -81,29 +81,11 @@ describe('Grouped metrics reports app', () => {
         ];
       });
 
-      describe('with :usage_data_group_code_coverage_visit_total enabled', () => {
-        beforeEach(() => {
-          mountComponent({ usageDataITestingMetricsReportWidgetTotal: true });
-        });
+      it('tracks group_code_coverage_visit_total metric', () => {
+        findExpandButton().trigger('click');
 
-        it('tracks group_code_coverage_visit_total metric', () => {
-          findExpandButton().trigger('click');
-
-          expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
-          expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
-        });
-      });
-
-      describe('with :usage_data_group_code_coverage_visit_total disabled', () => {
-        beforeEach(() => {
-          mountComponent({ usageDataITestingMetricsReportWidgetTotal: false });
-        });
-
-        it('does not track group_code_coverage_visit_total metric', () => {
-          findExpandButton().trigger('click');
-
-          expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
-        });
+        expect(Api.trackRedisHllUserEvent).toHaveBeenCalledTimes(1);
+        expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
       });
     });
 

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -154,7 +154,6 @@
   category: testing
   redis_slot: testing
   aggregation: weekly
-  feature_flag: usage_data_i_testing_metrics_report_widget_total
 - name: i_testing_group_code_coverage_visit_total
   category: testing
   redis_slot: testing