Commit 82707c46 authored by Fatih Acet's avatar Fatih Acet Committed by Alejandro Rodríguez

Merge branch 'super-secret-login-upgrade' into 'master'

Revert signin tab order fix.

The history: 

> 1. @sytses created this:
> 2. The fix was submitted here:
> 3. I [made]( the same observation you did after it was merged
4. A long discussion about accessibility and UX followed, and we decided to revert all changes (

## Screenshots (if relevant)


## Does this MR meet the acceptance criteria?

- [x] [Changelog entry]( added
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](
- [x] Conform by the [style guides](
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](

## What are the relevant issue numbers?


See merge request !7538
parent 55196497
......@@ -255,26 +255,3 @@
// For sign in pane only, to improve tab order, the following removes the submit button from
// normal document flow and pins it to the bottom of the form. For context, see !6867 & !6928
.login-box {
.new_user {
position: relative;
padding-bottom: 35px;
@media (min-width: $screen-sm-min) and (max-width: $screen-sm-max) {
.forgot-password {
float: none !important;
margin-top: 5px;
.move-submit-down {
position: absolute;
width: 100%;
bottom: 0;
......@@ -5,8 +5,6 @@
= f.label :password
= f.password_field :password, class: "form-control bottom", required: true, title: "This field is required."
= f.submit "Sign in", class: "btn btn-save"
- if devise_mapping.rememberable?
%label{for: "user_remember_me"}
......@@ -14,3 +12,5 @@
%span Remember me
= link_to "Forgot your password?", new_password_path(resource_name)
= f.submit "Sign in", class: "btn btn-save"
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment