Commit 837aa950 authored by Tim Zallmann's avatar Tim Zallmann

Refined dropdown_filter id assignment

parent 85b64d5e
......@@ -102,8 +102,7 @@ module DropdownsHelper
def dropdown_filter(placeholder, search_id: nil)
content_tag :div, class: "dropdown-input" do
dropdown_id = search_id || (placeholder&.parameterize || "filter") + "-dropdown-input-" + rand(1..100).to_s
filter_output = search_field_tag dropdown_id, nil, data: { qa_selector: "dropdown_input_field" }, class: "dropdown-input-field", placeholder: placeholder, autocomplete: 'off'
filter_output = search_field_tag search_id, nil, data: { qa_selector: "dropdown_input_field" }, id: nil, class: "dropdown-input-field", placeholder: placeholder, autocomplete: 'off'
filter_output << sprite_icon('search', css_class: 'dropdown-input-search')
filter_output << sprite_icon('close', size: 16, css_class: 'dropdown-input-clear js-dropdown-input-clear')
......
- tab_name = local_assigns.fetch(:name, nil)
- tab_class = local_assigns.fetch(:class, nil)
- qa_selector = local_assigns.fetch(:qa_selector, nil)
- id = local_assigns.fetch(:id, nil)
- tab_id = local_assigns.fetch(:id, nil)
%li{ class: [tab_class, ("active" if params[:tab] == tab_name)], id: id || tab_class, data: { qa_selector: qa_selector } }
%li{ (tab_id ? { id: tab_id } : {}), class: [tab_class, ("active" if params[:tab] == tab_name)], data: { qa_selector: qa_selector } }
= yield
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment