Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
83965105
Commit
83965105
authored
Apr 26, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[skip ci] refactor clicked parameters into options
parent
0d3ecf58
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
19 additions
and
9 deletions
+19
-9
app/assets/javascripts/gl_dropdown.js
app/assets/javascripts/gl_dropdown.js
+1
-1
app/assets/javascripts/issue_status_select.js
app/assets/javascripts/issue_status_select.js
+2
-2
app/assets/javascripts/labels_select.js
app/assets/javascripts/labels_select.js
+4
-1
app/assets/javascripts/milestone_select.js
app/assets/javascripts/milestone_select.js
+4
-1
app/assets/javascripts/subscription_select.js
app/assets/javascripts/subscription_select.js
+2
-2
app/assets/javascripts/users_select.js
app/assets/javascripts/users_select.js
+2
-1
app/assets/javascripts/weight_select.js
app/assets/javascripts/weight_select.js
+4
-1
No files found.
app/assets/javascripts/gl_dropdown.js
View file @
83965105
...
...
@@ -351,7 +351,7 @@ GitLabDropdown = (function() {
isMarking
=
selected
?
selected
[
1
]
:
null
;
if
(
this
.
options
.
clicked
)
{
this
.
options
.
clicked
.
call
(
this
,
{
user
:
selectedObj
,
selectedObj
,
$el
,
e
,
isMarking
,
...
...
app/assets/javascripts/issue_status_select.js
View file @
83965105
...
...
@@ -19,8 +19,8 @@
return
label
;
};
})(
this
),
clicked
:
function
(
item
,
$el
,
e
)
{
return
e
.
preventDefault
();
clicked
:
function
(
options
)
{
return
options
.
e
.
preventDefault
();
},
id
:
function
(
obj
,
el
)
{
return
$
(
el
).
data
(
"
id
"
);
...
...
app/assets/javascripts/labels_select.js
View file @
83965105
...
...
@@ -330,7 +330,10 @@
},
multiSelect
:
$dropdown
.
hasClass
(
'
js-multiselect
'
),
vue
:
$dropdown
.
hasClass
(
'
js-issue-board-sidebar
'
),
clicked
:
function
(
label
,
$el
,
e
,
isMarking
)
{
clicked
:
function
(
options
)
{
const
{
$el
,
e
,
isMarking
}
=
options
;
const
label
=
options
.
selectedObj
;
var
isIssueIndex
,
isMRIndex
,
page
,
boardsModel
;
page
=
$
(
'
body
'
).
data
(
'
page
'
);
...
...
app/assets/javascripts/milestone_select.js
View file @
83965105
...
...
@@ -144,7 +144,10 @@ import Vue from 'vue';
return
true
;
},
clicked
:
function
(
selected
,
$el
,
e
)
{
clicked
:
function
(
options
)
{
const
{
$el
,
e
}
=
options
;
let
selected
=
options
.
selectedObj
;
var
data
,
isIssueIndex
,
isMRIndex
,
page
,
boardsStore
;
if
(
!
selected
)
return
;
page
=
$
(
'
body
'
).
data
(
'
page
'
);
...
...
app/assets/javascripts/subscription_select.js
View file @
83965105
...
...
@@ -19,8 +19,8 @@
return
label
;
};
})(
this
),
clicked
:
function
(
item
,
$el
,
e
)
{
return
e
.
preventDefault
();
clicked
:
function
(
options
)
{
return
options
.
e
.
preventDefault
();
},
id
:
function
(
obj
,
el
)
{
return
$
(
el
).
data
(
"
id
"
);
...
...
app/assets/javascripts/users_select.js
View file @
83965105
...
...
@@ -291,7 +291,8 @@ import eventHub from './sidebar/event_hub';
multiSelect
:
$dropdown
.
hasClass
(
'
js-multiselect
'
),
vue
:
$dropdown
.
hasClass
(
'
js-issue-board-sidebar
'
),
clicked
:
function
(
options
)
{
const
{
user
,
$el
,
e
,
isMarking
}
=
options
;
const
{
$el
,
e
,
isMarking
}
=
options
;
const
user
=
options
.
selectedObj
;
if
(
$dropdown
.
hasClass
(
'
js-multiselect
'
))
{
const
isActive
=
$el
.
hasClass
(
'
is-active
'
);
...
...
app/assets/javascripts/weight_select.js
View file @
83965105
...
...
@@ -54,7 +54,10 @@
return
''
;
}
},
clicked
:
function
(
selected
,
$el
,
e
)
{
clicked
:
function
(
options
)
{
const
e
=
options
.
e
;
let
selected
=
options
.
selectedObj
;
if
(
$
(
dropdown
).
is
(
"
.js-filter-submit
"
))
{
return
$
(
dropdown
).
parents
(
'
form
'
).
submit
();
}
else
if
(
$dropdown
.
is
(
'
.js-issuable-form-weight
'
))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment