Merge branch '249584-fix-broken-master' into 'master'

Ensure search results are ordered deterministically

Closes #249584

See merge request gitlab-org/gitlab!42381

spec/lib/gitlab/search_results_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe Gitlab::SearchResults do
   let(:merge_request) { create(:merge_request, source_project: project, title: 'foo') }
   let(:filters) { {} }
 
-  subject(:results) { described_class.new(user, 'foo', Project.all, filters: filters) }
+  subject(:results) { described_class.new(user, 'foo', Project.order(:id), filters: filters) }
 
   context 'as a user with access' do
     before do