Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8b91a695
Commit
8b91a695
authored
Dec 05, 2016
by
Bryce Johnson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Write unapproval integration test.
parent
977d1ca7
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
36 additions
and
5 deletions
+36
-5
spec/features/merge_requests/approvals_spec.rb
spec/features/merge_requests/approvals_spec.rb
+36
-5
No files found.
spec/features/merge_requests/approvals_spec.rb
View file @
8b91a695
...
...
@@ -162,8 +162,6 @@ feature 'Merge request approvals', js: true, feature: true do
end
context
'when group is assigned to a project'
do
it
'I am able to unapprove'
do
end
it
'I am able to approve'
do
create
:approver_group
,
group:
group
,
target:
project
...
...
@@ -175,12 +173,10 @@ feature 'Merge request approvals', js: true, feature: true do
expect
(
page
).
to
have_content
(
"Approved by"
)
end
end
context
'when group is assigned to a merge request'
do
it
'I am able to unapprove'
do
end
it
'I am able to approve'
do
create
:approver_group
,
group:
group
,
target:
merge_request
...
...
@@ -194,4 +190,39 @@ feature 'Merge request approvals', js: true, feature: true do
end
end
end
context
'Unapproving by approvers from groups'
do
let
(
:other_user
)
{
create
(
:user
)
}
let
(
:merge_request
)
{
create
(
:merge_request
,
source_project:
project
)
}
let
(
:group
)
{
create
:group
}
before
do
project
.
team
<<
[
user
,
:developer
]
group
.
add_developer
(
other_user
)
group
.
add_developer
(
user
)
login_as
(
user
)
create
:approver_group
,
group:
group
,
target:
project
visit
namespace_project_merge_request_path
(
project
.
namespace
,
project
,
merge_request
)
page
.
within
'.mr-state-widget'
do
click_button
'Approve Merge Request'
end
wait_for_ajax
end
it
'I am able to unapprove'
do
page
.
within
'.mr-state-widget'
do
click_button
'Remove your approval'
end
expect
(
page
).
not_to
have_content
(
"Approved by"
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment