Merge branch 'renovate/gitlab-uisvg' into 'master'

Update dependency @gitlab/ui to v23.12.0

See merge request gitlab-org/gitlab!47921

ee/app/assets/javascripts/approvals/components/rule_controls.vue

 <script>
 import { mapState, mapActions } from 'vuex';
-import { GlButton, GlIcon } from '@gitlab/ui';
+import { GlButton } from '@gitlab/ui';
 
 export default {
   components: {
     GlButton,
-    GlIcon,
   },
   props: {
     rule: {
@@ -31,9 +30,9 @@ export default {
       class="gl-ml-3 btn btn-inverted"
       variant="danger"
       category="primary"
+      icon="remove"
+      :aria-label="__('Remove')"
       @click="requestDeleteRule(rule)"
-    >
-      <gl-icon name="remove" :aria-label="__('Remove')" />
-    </gl-button>
+    />
   </div>
 </template>

ee/spec/frontend/analytics/code_review_analytics/components/__snapshots__/merge_request_table_spec.js.snap

@@ -125,6 +125,7 @@ exports[`MergeRequestTable component template matches the snapshot 1`] = `
                   class="d-flex align-items-center"
                 >
                   <svg
+                    aria-hidden="true"
                     class="mr-2 gl-icon s16"
                     data-testid="clock-icon"
                   >

ee/spec/frontend/analytics/productivity_analytics/components/__snapshots__/metric_chart_spec.js.snap

@@ -45,7 +45,7 @@ exports[`MetricChart component template when isLoading is false and chartData is
         class="d-flex"
       >
         <gl-icon-stub
-          aria-label="Selected"
+          arialabel="Selected"
           class="flex-shrink-0 gl-mr-2 invisible"
           name="mobile-issue-close"
           size="16"
@@ -69,7 +69,7 @@ exports[`MetricChart component template when isLoading is false and chartData is
         class="d-flex"
       >
         <gl-icon-stub
-          aria-label="Selected"
+          arialabel="Selected"
           class="flex-shrink-0 gl-mr-2 invisible"
           name="mobile-issue-close"
           size="16"

ee/spec/frontend/approvals/components/rule_controls_spec.js

-import { GlButton, GlIcon } from '@gitlab/ui';
+import { GlButton } from '@gitlab/ui';
 import { createLocalVue, shallowMount } from '@vue/test-utils';
 import Vuex from 'vuex';
 import RuleControls from 'ee/approvals/components/rule_controls.vue';
@@ -10,10 +10,7 @@ localVue.use(Vuex);
 
 const TEST_RULE = { id: 10 };
 
-const findButtonLabel = button => {
-  const icon = button.find(GlIcon);
-  return icon.exists() ? icon.attributes('aria-label') : button.text();
-};
+const findButtonLabel = button => button.attributes('aria-label') || button.text();
 const hasLabel = (button, label) => findButtonLabel(button) === label;
 
 describe('EE Approvals RuleControls', () => {

ee/spec/frontend/environments_dashboard/components/__snapshots__/environment_header_spec.js.snap

@@ -103,6 +103,7 @@ exports[`Environment Header renders name and link to app matches the snapshot 1`
       
   View app 
       <svg
+        aria-hidden="true"
         class="fgray gl-icon s16"
         data-testid="external-link-icon"
       >

ee/spec/frontend/geo_nodes/components/node_detail_sections/__snapshots__/node_details_section_main_spec.js.snap

@@ -19,6 +19,7 @@ exports[`NodeDetailsSectionMain template node url section renders section correc
   >
     http://127.0.0.1:3001/ 
     <svg
+      aria-hidden="true"
       class="gl-ml-1 gl-icon s16"
       data-testid="external-link-icon"
     >

ee/spec/frontend/incidents_settings/components/__snapshots__/service_level_agreement_form_spec.js.snap

@@ -3,6 +3,7 @@
 exports[`Alert integration settings form should match the default snapshot 1`] = `
 <gl-tab-stub
   title="Incident settings"
+  titlelinkclass=""
 >
   <gl-form-stub
     class="gl-pt-3"

ee/spec/frontend/on_demand_scans/components/profile_selector/__snapshots__/scanner_profile_selector_spec.js.snap

@@ -113,6 +113,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
                 type="button"
               >
                 <svg
+                  aria-hidden="true"
                   class="gl-icon s16 gl-new-dropdown-item-check-icon"
                   data-testid="mobile-issue-close-icon"
                 >
@@ -152,6 +153,7 @@ exports[`OnDemandScansScannerProfileSelector renders properly with profiles 1`]
                 type="button"
               >
                 <svg
+                  aria-hidden="true"
                   class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden"
                   data-testid="mobile-issue-close-icon"
                 >

ee/spec/frontend/on_demand_scans/components/profile_selector/__snapshots__/site_profile_selector_spec.js.snap

@@ -113,6 +113,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
                 type="button"
               >
                 <svg
+                  aria-hidden="true"
                   class="gl-icon s16 gl-new-dropdown-item-check-icon"
                   data-testid="mobile-issue-close-icon"
                 >
@@ -152,6 +153,7 @@ exports[`OnDemandScansSiteProfileSelector renders properly with profiles 1`] = `
                 type="button"
               >
                 <svg
+                  aria-hidden="true"
                   class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden"
                   data-testid="mobile-issue-close-icon"
                 >

ee/spec/frontend/security_dashboard/components/__snapshots__/unscanned_projects_spec.js.snap

@@ -41,6 +41,7 @@ exports[`UnscannedProjects component header matches the snapshot when the "helpP
       title="Project scanning help page"
     >
       <svg
+        aria-hidden="true"
         class="align-top gl-icon s12"
         data-testid="question-icon"
       >

ee/spec/frontend/threat_monitoring/components/__snapshots__/app_spec.js.snap

@@ -19,6 +19,7 @@ exports[`ThreatMonitoringApp component given there is a default environment with
 exports[`ThreatMonitoringApp component given there is a default environment with data renders the network policy tab 1`] = `
 <gl-tab-stub
   title="Policies"
+  titlelinkclass=""
 >
   <network-policy-list-stub
     documentationpath="/docs"

ee/spec/frontend/threat_monitoring/components/policy_editor/__snapshots__/policy_preview_spec.js.snap

@@ -8,6 +8,7 @@ exports[`PolicyPreview component renders policy preview tabs 1`] = `
 >
   <gl-tab-stub
     title=".yaml"
+    titlelinkclass=""
   >
     <pre
       class="gl-bg-white gl-rounded-top-left-none gl-rounded-top-right-none"
@@ -18,6 +19,7 @@ exports[`PolicyPreview component renders policy preview tabs 1`] = `
    
   <gl-tab-stub
     title="Rule"
+    titlelinkclass=""
   >
     <div
       class="gl-bg-white gl-rounded-top-left-none gl-rounded-top-right-none gl-rounded-bottom-left-base gl-rounded-bottom-right-base gl-py-3 gl-px-4 gl-border-1 gl-border-solid gl-border-gray-100"

ee/spec/frontend/vue_shared/security_reports/components/__snapshots__/event_item_spec.js.snap

@@ -8,6 +8,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
     class="circle-icon-container gl-flex-shrink-0 gl-align-self-start ci-status-icon-success"
   >
     <svg
+      aria-hidden="true"
       class="gl-icon s16"
       data-testid="plus-icon"
     >
@@ -87,6 +88,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
       <!---->
        
       <svg
+        aria-hidden="true"
         class="gl-button-icon gl-icon s16"
         data-testid="pencil-icon"
       >
@@ -105,6 +107,7 @@ exports[`Event Item with action buttons renders the action buttons 1`] = `
       <!---->
        
       <svg
+        aria-hidden="true"
         class="gl-button-icon gl-icon s16"
         data-testid="remove-icon"
       >

package.json

@@ -44,7 +44,7 @@
     "@babel/preset-env": "^7.10.1",
     "@gitlab/at.js": "1.5.5",
     "@gitlab/svgs": "1.175.0",
-    "@gitlab/ui": "23.9.0",
+    "@gitlab/ui": "23.12.0",
     "@gitlab/visual-review-tools": "1.6.1",
     "@rails/actioncable": "^6.0.3-3",
     "@rails/ujs": "^6.0.3-2",

spec/frontend/add_context_commits_modal/components/__snapshots__/add_context_commits_modal_spec.js.snap

@@ -18,7 +18,9 @@ exports[`AddContextCommitsModal renders modal with 2 tabs 1`] = `
     theme="indigo"
     value="0"
   >
-    <gl-tab-stub>
+    <gl-tab-stub
+      titlelinkclass=""
+    >
        
       <div
         class="mt-2"
@@ -37,7 +39,9 @@ exports[`AddContextCommitsModal renders modal with 2 tabs 1`] = `
       </div>
     </gl-tab-stub>
      
-    <gl-tab-stub>
+    <gl-tab-stub
+      titlelinkclass=""
+    >
        
       <review-tab-container-stub
         commits=""

spec/frontend/alerts_settings/__snapshots__/alerts_settings_form_new_spec.js.snap

@@ -28,7 +28,7 @@ exports[`AlertsSettingsFormNew with default values renders the initial template
       <div id=\\"integration-webhook\\" role=\\"group\\" class=\\"form-group gl-form-group\\"><label id=\\"integration-webhook__BV_label_\\" for=\\"integration-webhook\\" class=\\"d-block col-form-label\\">3. Set up webhook</label>
         <div class=\\"bv-no-focus-ring\\"><span>Utilize the URL and authorization key below to authorize an external service to send alerts to GitLab. Review your external service's documentation to learn where to add these details, and the <a rel=\\"noopener noreferrer\\" target=\\"_blank\\" href=\\"https://docs.gitlab.com/ee/operations/incident_management/alert_integrations.html\\" class=\\"gl-link gl-display-inline-block\\">GitLab documentation</a> to learn more about configuring your endpoint.</span> <label class=\\"gl-display-flex gl-flex-direction-column gl-mb-0 gl-w-max-content gl-my-4 gl-font-weight-normal\\">
             <div class=\\"gl-toggle-wrapper\\"><span class=\\"gl-toggle-label\\">Active</span>
-              <!----> <button aria-label=\\"Active\\" type=\\"button\\" class=\\"gl-toggle\\"><span class=\\"toggle-icon\\"><svg data-testid=\\"close-icon\\" class=\\"gl-icon s16\\"><use href=\\"#close\\"></use></svg></span></button></div>
+              <!----> <button aria-label=\\"Active\\" type=\\"button\\" class=\\"gl-toggle\\"><span class=\\"toggle-icon\\"><svg data-testid=\\"close-icon\\" aria-hidden=\\"true\\" class=\\"gl-icon s16\\"><use href=\\"#close\\"></use></svg></span></button></div>
             <!---->
           </label>
           <!---->
@@ -40,7 +40,7 @@ exports[`AlertsSettingsFormNew with default values renders the initial template
                 <!---->
                 <!----> <input id=\\"url\\" type=\\"text\\" readonly=\\"readonly\\" class=\\"gl-form-input form-control\\">
                 <div class=\\"input-group-append\\"><button title=\\"Copy\\" data-clipboard-text=\\"\\" aria-label=\\"Copy this value\\" type=\\"button\\" class=\\"btn gl-m-0! btn-default btn-md gl-button btn-default-secondary btn-icon\\">
-                    <!----> <svg data-testid=\\"copy-to-clipboard-icon\\" class=\\"gl-button-icon gl-icon s16\\">
+                    <!----> <svg data-testid=\\"copy-to-clipboard-icon\\" aria-hidden=\\"true\\" class=\\"gl-button-icon gl-icon s16\\">
                       <use href=\\"#copy-to-clipboard\\"></use>
                     </svg>
                     <!----></button></div>
@@ -56,7 +56,7 @@ exports[`AlertsSettingsFormNew with default values renders the initial template
                 <!---->
                 <!----> <input id=\\"authorization-key\\" type=\\"text\\" readonly=\\"readonly\\" class=\\"gl-form-input form-control\\">
                 <div class=\\"input-group-append\\"><button title=\\"Copy\\" data-clipboard-text=\\"\\" aria-label=\\"Copy this value\\" type=\\"button\\" class=\\"btn gl-m-0! btn-default btn-md gl-button btn-default-secondary btn-icon\\">
-                    <!----> <svg data-testid=\\"copy-to-clipboard-icon\\" class=\\"gl-button-icon gl-icon s16\\">
+                    <!----> <svg data-testid=\\"copy-to-clipboard-icon\\" aria-hidden=\\"true\\" class=\\"gl-button-icon gl-icon s16\\">
                       <use href=\\"#copy-to-clipboard\\"></use>
                     </svg>
                     <!----></button></div>

spec/frontend/clusters/components/__snapshots__/remove_cluster_confirmation_spec.js.snap

@@ -53,6 +53,7 @@ exports[`Remove cluster confirmation modal renders splitbutton with modal includ
           type="button"
         >
           <svg
+            aria-hidden="true"
             class="gl-icon s16 gl-new-dropdown-item-check-icon"
             data-testid="mobile-issue-close-icon"
           >
@@ -107,6 +108,7 @@ exports[`Remove cluster confirmation modal renders splitbutton with modal includ
           type="button"
         >
           <svg
+            aria-hidden="true"
             class="gl-icon s16 gl-new-dropdown-item-check-icon gl-visibility-hidden"
             data-testid="mobile-issue-close-icon"
           >

spec/frontend/code_navigation/components/__snapshots__/popover_spec.js.snap

@@ -17,6 +17,7 @@ exports[`Code navigation popover component renders popover 1`] = `
   >
     <gl-tab-stub
       title="Definition"
+      titlelinkclass=""
     >
       <div
         class="overflow-auto code-navigation-popover-container"
@@ -76,6 +77,7 @@ exports[`Code navigation popover component renders popover 1`] = `
     <gl-tab-stub
       class="py-2"
       data-testid="references-tab"
+      titlelinkclass=""
     >
        
       <p

spec/frontend/incidents_settings/components/__snapshots__/incidents_settings_tabs_spec.js.snap

@@ -43,6 +43,7 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
     >
       <gl-tab-stub
         title="Alert integration"
+        titlelinkclass=""
       >
         <alertssettingsform-stub
           class="gl-pt-3"
@@ -51,6 +52,7 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
       </gl-tab-stub>
       <gl-tab-stub
         title="PagerDuty integration"
+        titlelinkclass=""
       >
         <pagerdutysettingsform-stub
           class="gl-pt-3"

spec/frontend/issuable/related_issues/components/issue_token_spec.js

@@ -100,7 +100,7 @@ describe('IssueToken', () => {
         state,
       });
 
-      expect(findReferenceIcon().attributes('aria-label')).toBe(state);
+      expect(findReferenceIcon().props('ariaLabel')).toBe(state);
       expect(findReference().text()).toBe(displayReference);
       expect(findTitle().text()).toBe(title);
     });

spec/frontend/jira_import/components/__snapshots__/jira_import_form_spec.js.snap

@@ -120,6 +120,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
               class="gl-search-box-by-type"
             >
               <svg
+                aria-hidden="true"
                 class="gl-search-box-by-type-search-icon gl-icon s16"
                 data-testid="search-icon"
               >
@@ -234,6 +235,7 @@ exports[`JiraImportForm table body shows correct information in each cell 1`] =
               class="gl-search-box-by-type"
             >
               <svg
+                aria-hidden="true"
                 class="gl-search-box-by-type-search-icon gl-icon s16"
                 data-testid="search-icon"
               >

spec/frontend/vue_shared/components/__snapshots__/expand_button_spec.js.snap

@@ -11,6 +11,7 @@ exports[`Expand button on click when short text is provided renders button after
     <!---->
      
     <svg
+      aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
     >
@@ -39,6 +40,7 @@ exports[`Expand button on click when short text is provided renders button after
     <!---->
      
     <svg
+      aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
     >
@@ -62,6 +64,7 @@ exports[`Expand button when short text is provided renders button before text 1`
     <!---->
      
     <svg
+      aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
     >
@@ -90,6 +93,7 @@ exports[`Expand button when short text is provided renders button before text 1`
     <!---->
      
     <svg
+      aria-hidden="true"
       class="gl-button-icon gl-icon s16"
       data-testid="ellipsis_h-icon"
     >

spec/frontend/vue_shared/components/registry/__snapshots__/code_instruction_spec.js.snap

@@ -47,6 +47,7 @@ exports[`Package code instruction single line to match the default snapshot 1`]
         <!---->
          
         <svg
+          aria-hidden="true"
           class="gl-button-icon gl-icon s16"
           data-testid="copy-to-clipboard-icon"
         >

yarn.lock

@@ -866,10 +866,10 @@
   resolved "https://registry.yarnpkg.com/@gitlab/svgs/-/svgs-1.175.0.tgz#734f341784af1cd1d62d160a17bcdfb61ff7b04d"
   integrity sha512-gXpc87TGSXIzfAr4QER1Qw1v3P47pBO6BXkma52blgwXVmcFNe3nhQzqsqt66wKNzrIrk3lAcB4GUyPHbPVXpg==
 
-"@gitlab/ui@23.9.0":
-  version "23.9.0"
-  resolved "https://registry.yarnpkg.com/@gitlab/ui/-/ui-23.9.0.tgz#e21966130b41e624dbe4505911a79afb731c2d6b"
-  integrity sha512-IfaiIcRw6iKE9Fxx36LQ1Afa/fcdmvRQCJO9igc+wWD3MFZGU/ggsQw3SExkkYI6XYmDUr56CT/o+HYlCDjgZQ==
+"@gitlab/ui@23.12.0":
+  version "23.12.0"
+  resolved "https://registry.yarnpkg.com/@gitlab/ui/-/ui-23.12.0.tgz#a71240b659bf37f5ea118fa0948d22d8c304d811"
+  integrity sha512-ibnvGx7PmMjVFcHJeGXInr5PZBHhzexyH1vrpjktlHhmQfi5gbcOwHOcXrBpLqmAW5o2F8jFx2aXBZeuGMpEkg==
   dependencies:
     "@babel/standalone" "^7.0.0"
     "@gitlab/vue-toasted" "^1.3.0"