Commit 8cfc6a4d authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge pull request #3956 from AlexDenisov/issues_bulk_update

Issues bulk update
parents d7c65534 6e8cb844
...@@ -8,6 +8,16 @@ module Issues ...@@ -8,6 +8,16 @@ module Issues
assignee_id = update_data[:assignee_id] assignee_id = update_data[:assignee_id]
status = update_data[:status] status = update_data[:status]
new_state = nil
if status.present?
if status == 'closed'
new_state = :close
else
new_state = :reopen
end
end
opts = {} opts = {}
opts[:milestone_id] = milestone_id if milestone_id.present? opts[:milestone_id] = milestone_id if milestone_id.present?
opts[:assignee_id] = assignee_id if assignee_id.present? opts[:assignee_id] = assignee_id if assignee_id.present?
...@@ -17,14 +27,7 @@ module Issues ...@@ -17,14 +27,7 @@ module Issues
issues.each do |issue| issues.each do |issue|
issue.update_attributes(opts) issue.update_attributes(opts)
issue.send new_state if new_state
if status.present?
if status == 'closed'
issue.close
else
issue.reopen
end
end
end end
{ {
......
require 'spec_helper'
describe Issues::BulkUpdateContext do
let(:issue) {
create(:issue, project: @project)
}
before do
@user = create :user
opts = {
name: "GitLab"
}
@project = Projects::CreateContext.new(@user, opts).execute
end
describe :close_issue do
before do
@issues = 5.times.collect do
create(:issue, project: @project)
end
@params = {
update: {
status: 'closed',
issues_ids: @issues.map(&:id)
}
}
end
it {
result = Issues::BulkUpdateContext.new(@project, @user, @params).execute
result[:success].should be_true
result[:count].should == @issues.count
@project.issues.opened.should be_empty
@project.issues.closed.should_not be_empty
}
end
describe :reopen_issues do
before do
@issues = 5.times.collect do
create(:closed_issue, project: @project)
end
@params = {
update: {
status: 'reopen',
issues_ids: @issues.map(&:id)
}
}
end
it {
result = Issues::BulkUpdateContext.new(@project, @user, @params).execute
result[:success].should be_true
result[:count].should == @issues.count
@project.issues.closed.should be_empty
@project.issues.opened.should_not be_empty
}
end
describe :update_assignee do
before do
@new_assignee = create :user
@params = {
update: {
issues_ids: [issue.id],
assignee_id: @new_assignee.id
}
}
end
it {
result = Issues::BulkUpdateContext.new(@project, @user, @params).execute
result[:success].should be_true
result[:count].should == 1
@project.issues.first.assignee.should == @new_assignee
}
end
describe :update_milestone do
before do
@milestone = create :milestone
@params = {
update: {
issues_ids: [issue.id],
milestone_id: @milestone.id
}
}
end
it {
result = Issues::BulkUpdateContext.new(@project, @user, @params).execute
result[:success].should be_true
result[:count].should == 1
@project.issues.first.milestone.should == @milestone
}
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment