Commit 8d53e3a2 authored by Heinrich Lee Yu's avatar Heinrich Lee Yu

Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-search' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/search

See merge request gitlab-org/gitlab!58326
parents 53a92763 3a064535
...@@ -726,9 +726,6 @@ RSpec/EmptyLineAfterFinalLetItBe: ...@@ -726,9 +726,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- ee/spec/services/requirements_management/update_requirement_service_spec.rb - ee/spec/services/requirements_management/update_requirement_service_spec.rb
- ee/spec/services/resource_access_tokens/create_service_spec.rb - ee/spec/services/resource_access_tokens/create_service_spec.rb
- ee/spec/services/resource_access_tokens/revoke_service_spec.rb - ee/spec/services/resource_access_tokens/revoke_service_spec.rb
- ee/spec/services/search/global_service_spec.rb
- ee/spec/services/search/group_service_spec.rb
- ee/spec/services/search/project_service_spec.rb
- ee/spec/services/security/auto_fix_label_service_spec.rb - ee/spec/services/security/auto_fix_label_service_spec.rb
- ee/spec/services/security/store_grouped_scans_service_spec.rb - ee/spec/services/security/store_grouped_scans_service_spec.rb
- ee/spec/services/security/store_report_service_spec.rb - ee/spec/services/security/store_report_service_spec.rb
......
---
title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/search
merge_request: 58326
author: Abdul Wadood @abdulwd
type: fixed
...@@ -46,6 +46,7 @@ RSpec.describe Search::GlobalService do ...@@ -46,6 +46,7 @@ RSpec.describe Search::GlobalService do
end end
let_it_be(:group) { create(:group) } let_it_be(:group) { create(:group) }
let(:project) { create(:project, project_level, namespace: group) } let(:project) { create(:project, project_level, namespace: group) }
let(:user) { create_user_from_membership(project, membership) } let(:user) { create_user_from_membership(project, membership) }
......
...@@ -70,6 +70,7 @@ RSpec.describe Search::GroupService, :elastic do ...@@ -70,6 +70,7 @@ RSpec.describe Search::GroupService, :elastic do
context 'notes search' do context 'notes search' do
let_it_be(:group) { create(:group) } let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, namespace: group) } let_it_be(:project) { create(:project, namespace: group) }
let(:results) { described_class.new(nil, group, search: 'test').execute.objects('notes') } let(:results) { described_class.new(nil, group, search: 'test').execute.objects('notes') }
it_behaves_like 'search query applies joins based on migrations shared examples', :add_permissions_data_to_notes_documents it_behaves_like 'search query applies joins based on migrations shared examples', :add_permissions_data_to_notes_documents
...@@ -93,6 +94,7 @@ RSpec.describe Search::GroupService, :elastic do ...@@ -93,6 +94,7 @@ RSpec.describe Search::GroupService, :elastic do
end end
let_it_be(:group) { create(:group) } let_it_be(:group) { create(:group) }
let!(:project) { create(:project, project_level, namespace: group) } let!(:project) { create(:project, project_level, namespace: group) }
let!(:project2) { create(:project, project_level) } let!(:project2) { create(:project, project_level) }
let(:user) { create_user_from_membership(project, membership) } let(:user) { create_user_from_membership(project, membership) }
......
...@@ -36,6 +36,7 @@ RSpec.describe Search::ProjectService do ...@@ -36,6 +36,7 @@ RSpec.describe Search::ProjectService do
context 'notes search' do context 'notes search' do
let_it_be(:project) { create(:project) } let_it_be(:project) { create(:project) }
let(:results) { described_class.new(project, nil, search: 'test').execute.objects('notes') } let(:results) { described_class.new(project, nil, search: 'test').execute.objects('notes') }
it_behaves_like 'search query applies joins based on migrations shared examples', :add_permissions_data_to_notes_documents it_behaves_like 'search query applies joins based on migrations shared examples', :add_permissions_data_to_notes_documents
...@@ -59,6 +60,7 @@ RSpec.describe Search::ProjectService do ...@@ -59,6 +60,7 @@ RSpec.describe Search::ProjectService do
end end
let_it_be(:group) { create(:group) } let_it_be(:group) { create(:group) }
let!(:project) { create(:project, project_level, namespace: group) } let!(:project) { create(:project, project_level, namespace: group) }
let!(:project2) { create(:project, project_level) } let!(:project2) { create(:project, project_level) }
let(:user) { create_user_from_membership(project, membership) } let(:user) { create_user_from_membership(project, membership) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment