Commit 8e20e899 authored by Ash McKenzie's avatar Ash McKenzie Committed by Douglas Barbosa Alexandre

Include current host string for all log entries

parent ab2403e3
---
title: 'Geo: Include host when logging'
merge_request: 22203
author:
type: other
...@@ -52,6 +52,7 @@ module Gitlab ...@@ -52,6 +52,7 @@ module Gitlab
def base_log_data(message, params = {}) def base_log_data(message, params = {})
{ {
pid: PID, pid: PID,
host: Gitlab.config.gitlab.host,
class: caller_name, class: caller_name,
message: message message: message
}.merge(params) }.merge(params)
......
...@@ -23,6 +23,7 @@ module Gitlab ...@@ -23,6 +23,7 @@ module Gitlab
def base_log_data(message) def base_log_data(message)
{ {
class: self.class.name, class: self.class.name,
host: Gitlab.config.gitlab.host,
message: message, message: message,
job_id: get_sidekiq_job_id job_id: get_sidekiq_job_id
}.merge(extra_log_data).compact }.merge(extra_log_data).compact
......
...@@ -29,6 +29,7 @@ describe Gitlab::Geo::LogCursor::Lease, :clean_gitlab_redis_shared_state do ...@@ -29,6 +29,7 @@ describe Gitlab::Geo::LogCursor::Lease, :clean_gitlab_redis_shared_state do
expect(::Gitlab::Logger).to receive(:debug).with(pid: 111, expect(::Gitlab::Logger).to receive(:debug).with(pid: 111,
class: 'Gitlab::Geo::LogCursor::Lease', class: 'Gitlab::Geo::LogCursor::Lease',
host: "localhost",
message: 'Lease renewed.') message: 'Lease renewed.')
described_class.renew! described_class.renew!
......
...@@ -7,7 +7,7 @@ describe Gitlab::Geo::LogCursor::Logger, :geo do ...@@ -7,7 +7,7 @@ describe Gitlab::Geo::LogCursor::Logger, :geo do
subject(:logger) { described_class.new(LoggerSpec) } subject(:logger) { described_class.new(LoggerSpec) }
let(:data) { { pid: 111, class: 'LoggerSpec', message: 'Test' } } let(:data) { { pid: 111, class: 'LoggerSpec', host: 'localhost', message: 'Test' } }
before do before do
stub_const("#{described_class.name}::PID", 111) stub_const("#{described_class.name}::PID", 111)
...@@ -35,6 +35,7 @@ describe Gitlab::Geo::LogCursor::Logger, :geo do ...@@ -35,6 +35,7 @@ describe Gitlab::Geo::LogCursor::Logger, :geo do
it 'logs an info event' do it 'logs an info event' do
expect(::Gitlab::Logger).to receive(:info).with(pid: 111, expect(::Gitlab::Logger).to receive(:info).with(pid: 111,
class: "LoggerSpec", class: "LoggerSpec",
host: 'localhost',
message: 'Test', message: 'Test',
cursor_delay_s: 0.0) cursor_delay_s: 0.0)
......
...@@ -23,6 +23,7 @@ describe Gitlab::Geo::LogHelpers do ...@@ -23,6 +23,7 @@ describe Gitlab::Geo::LogHelpers do
context 'Sidekiq context' do context 'Sidekiq context' do
it 'does not log empty job_id when running outside of job' do it 'does not log empty job_id when running outside of job' do
expect(Gitlab::Geo::Logger).to receive(:error).with({ class: 'FakeLogHelpersConsumer', expect(Gitlab::Geo::Logger).to receive(:error).with({ class: 'FakeLogHelpersConsumer',
host: 'localhost',
message: 'Test message' }) message: 'Test message' })
FakeLogHelpersConsumer.new.execute FakeLogHelpersConsumer.new.execute
...@@ -30,6 +31,7 @@ describe Gitlab::Geo::LogHelpers do ...@@ -30,6 +31,7 @@ describe Gitlab::Geo::LogHelpers do
it 'logs sidekiq_context' do it 'logs sidekiq_context' do
expect(Gitlab::Geo::Logger).to receive(:error).with({ class: 'FakeLogHelpersConsumer', expect(Gitlab::Geo::Logger).to receive(:error).with({ class: 'FakeLogHelpersConsumer',
host: 'localhost',
message: 'Test message', message: 'Test message',
job_id: '5b9b108c7558fe3c32cc61a5' }) job_id: '5b9b108c7558fe3c32cc61a5' })
......
...@@ -30,6 +30,7 @@ describe Geo::CacheInvalidationEventStore do ...@@ -30,6 +30,7 @@ describe Geo::CacheInvalidationEventStore do
expected_message = { expected_message = {
class: described_class.name, class: described_class.name,
host: "localhost",
cache_key: '', cache_key: '',
message: 'Cache invalidation event could not be created', message: 'Cache invalidation event could not be created',
error: "Validation failed: Key can't be blank" error: "Validation failed: Key can't be blank"
......
...@@ -37,6 +37,7 @@ describe Geo::JobArtifactDeletedEventStore do ...@@ -37,6 +37,7 @@ describe Geo::JobArtifactDeletedEventStore do
expected_message = { expected_message = {
class: "Geo::JobArtifactDeletedEventStore", class: "Geo::JobArtifactDeletedEventStore",
host: "localhost",
job_artifact_id: invalid_job_artifact.id, job_artifact_id: invalid_job_artifact.id,
file_path: nil, file_path: nil,
project_id: project.id, project_id: project.id,
......
...@@ -37,6 +37,7 @@ describe Geo::LfsObjectDeletedEventStore do ...@@ -37,6 +37,7 @@ describe Geo::LfsObjectDeletedEventStore do
expected_message = { expected_message = {
class: "Geo::LfsObjectDeletedEventStore", class: "Geo::LfsObjectDeletedEventStore",
host: "localhost",
lfs_object_id: invalid_lfs_object.id, lfs_object_id: invalid_lfs_object.id,
file_path: nil, file_path: nil,
message: "Lfs object deleted event could not be created", message: "Lfs object deleted event could not be created",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment