Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8efa88a3
Commit
8efa88a3
authored
Apr 25, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed feature spec not waiting for ajax request to finish
Fixed 404 in project milestones when not logged in
parent
79c7188a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletion
+4
-1
app/controllers/projects/milestones_controller.rb
app/controllers/projects/milestones_controller.rb
+1
-1
spec/features/milestones/milestones_spec.rb
spec/features/milestones/milestones_spec.rb
+3
-0
No files found.
app/controllers/projects/milestones_controller.rb
View file @
8efa88a3
...
@@ -8,7 +8,7 @@ class Projects::MilestonesController < Projects::ApplicationController
...
@@ -8,7 +8,7 @@ class Projects::MilestonesController < Projects::ApplicationController
before_action
:authorize_read_milestone!
before_action
:authorize_read_milestone!
# Allow admin milestone
# Allow admin milestone
before_action
:authorize_admin_milestone!
,
except:
[
:index
,
:show
]
before_action
:authorize_admin_milestone!
,
except:
[
:index
,
:show
,
:merge_requests
,
:participants
,
:labels
]
respond_to
:html
respond_to
:html
...
...
spec/features/milestones/milestones_spec.rb
View file @
8efa88a3
...
@@ -86,6 +86,9 @@ describe 'Milestone draggable', feature: true, js: true do
...
@@ -86,6 +86,9 @@ describe 'Milestone draggable', feature: true, js: true do
visit
namespace_project_milestone_path
(
project
.
namespace
,
project
,
milestone
)
visit
namespace_project_milestone_path
(
project
.
namespace
,
project
,
milestone
)
page
.
find
(
"a[href='#tab-merge-requests']"
).
click
page
.
find
(
"a[href='#tab-merge-requests']"
).
click
wait_for_ajax
scroll_into_view
(
'.milestone-content'
)
scroll_into_view
(
'.milestone-content'
)
drag_to
(
selector:
'.merge_requests-sortable-list'
,
list_to_index:
1
)
drag_to
(
selector:
'.merge_requests-sortable-list'
,
list_to_index:
1
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment